roachtest: don't set changefeed.push.enabled #52928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
andreimatei
reviewed
Aug 17, 2020
There was a problem hiding this comment.
LGTM thanks
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @andreimatei)
nvanbenschoten
force-pushed
the
nvanbenschoten/changefeedPush
branch
from
922187c to
6878f5f
Compare
Fixes cockroachdb#52875. Fixes cockroachdb#52874. Fixes cockroachdb#52873. Fixes cockroachdb#52872. Fixes cockroachdb#52871. Fixes cockroachdb#52870. Fixes cockroachdb#52856. Fixes cockroachdb#52855. Fixes cockroachdb#52854. Fixes cockroachdb#52853. Fixes cockroachdb#52852. Fixes cockroachdb#52544. In 8a81eac, we stopped ignoring "unknown cluster setting" errors when setting `changefeed.push.enabled` in a number of cdc tests. The comment on the code mentioned v2.1, but it turns out that it was also saving us on v19.2 onward because this cluster setting was removed in v19.2 in c7a195c. We can remove the code to set the cluster setting entirely. It's dead code when testing v19.2 onward, and the cluster setting defaults to [`true` in v19.1](https://github.com/cockroachdb/cockroach/blob/cebc92d5ad596d721382df9ef18fac2ded589547/pkg/ccl/changefeedccl/changefeed.go#L48).
We only support back to v19.1, so these MinVersions are not needed anymore.
nvanbenschoten
force-pushed
the
nvanbenschoten/changefeedPush
branch
from
6878f5f to
43b10ce
Compare
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #52875.
Fixes #52874.
Fixes #52873.
Fixes #52872.
Fixes #52871.
Fixes #52870.
Fixes #52856.
Fixes #52855.
Fixes #52854.
Fixes #52853.
Fixes #52852.
Fixes #52544.
In 8a81eac, we stopped ignoring "unknown cluster setting" errors when setting
changefeed.push.enabledin a number of cdc tests. The comment on the code mentioned v2.1, but it turns out that it was also saving us on v19.2 onward because this cluster setting was removed in v19.2 in c7a195c.We can remove the code to set the cluster setting entirely. It's dead code when testing v19.2 onward, and the cluster setting defaults to
truein v19.1.