Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roachtest: cdc/initial-scan failed #52871

Closed
cockroach-teamcity opened this issue Aug 16, 2020 · 0 comments · Fixed by #52928
Closed

roachtest: cdc/initial-scan failed #52871

cockroach-teamcity opened this issue Aug 16, 2020 · 0 comments · Fixed by #52928
Labels
C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked.
Milestone
20.2

Comments

@cockroach-teamcity
Copy link
Member

(roachtest).cdc/initial-scan failed on provisional_202008151325_v19.2.10@13350e2bebf99997730262bce26b843ed3ecb1be:

The test failed on branch=provisional_202008151325_v19.2.10, cloud=gce:
test artifacts and logs in: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/artifacts/cdc/initial-scan/run_1
	cdc.go:69,cdc.go:511,test_runner.go:754: pq: unknown cluster setting 'changefeed.push.enabled'
More

Artifacts: /cdc/initial-scan
Related:

See this test on roachdash
powered by pkg/cmd/internal/issues
@cockroach-teamcity cockroach-teamcity added branch-provisional_202008151325_v19.2.10 C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. labels Aug 16, 2020
@cockroach-teamcity cockroach-teamcity added this to the 20.2 milestone Aug 16, 2020
@nvanbenschoten nvanbenschoten mentioned this issue Aug 17, 2020
Merged
craig bot pushed a commit that referenced this issue Aug 18, 2020
@nvanbenschoten
Merge #52928
22a31b6 
52928: roachtest: don't set changefeed.push.enabled r=nvanbenschoten a=nvanbenschoten

Fixes #52875.
Fixes #52874.
Fixes #52873.
Fixes #52872.
Fixes #52871.
Fixes #52870.
Fixes #52856.
Fixes #52855.
Fixes #52854.
Fixes #52853.
Fixes #52852.
Fixes #52544.

In 8a81eac, we stopped ignoring "unknown cluster setting" errors when setting `changefeed.push.enabled` in a number of cdc tests. The comment on the code mentioned v2.1, but it turns out that it was also saving us on v19.2 onward because this cluster setting was removed in v19.2 in c7a195c.

We can remove the code to set the cluster setting entirely. It's dead code when testing v19.2 onward, and the cluster setting defaults to [`true` in v19.1](https://github.com/cockroachdb/cockroach/blob/cebc92d5ad596d721382df9ef18fac2ded589547/pkg/ccl/changefeedccl/changefeed.go#L48).


Co-authored-by: Nathan VanBenschoten <[email protected]>
@craig craig bot closed this as completed in 169aad5 Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked.
Projects
None yet
Milestone
20.2
Development

Successfully merging a pull request may close this issue.

roachtest: don't set changefeed.push.enabled nvanbenschoten/cockroach
1 participant
@cockroach-teamcity