Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roachtest: cdc/tpcc-1000/rangefeed=true failed #52544

Closed
cockroach-teamcity opened this issue Aug 9, 2020 · 1 comment · Fixed by #52928
Closed

roachtest: cdc/tpcc-1000/rangefeed=true failed #52544

cockroach-teamcity opened this issue Aug 9, 2020 · 1 comment · Fixed by #52928
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked.
Milestone
20.2

Comments

@cockroach-teamcity
Copy link
Member

(roachtest).cdc/tpcc-1000/rangefeed=true failed on master@cf44e2e11363a43de2c13987378a3fe50b460e08:


	cluster.go:2556,cdc.go:216,cdc.go:515,test_runner.go:754: monitor failure: monitor task failed: dial tcp 34.70.108.130:26257: connect: connection refused
		(1) attached stack trace
		  | main.(*monitor).WaitE
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/cluster.go:2544
		  | main.(*monitor).Wait
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/cluster.go:2552
		  | main.cdcBasicTest
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/cdc.go:216
		  | main.registerCDC.func1
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/cdc.go:515
		  | [...repeated from below...]
		Wraps: (2) monitor failure
		Wraps: (3) attached stack trace
		  | main.(*monitor).wait.func2
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachtest/cluster.go:2600
		  | runtime.goexit
		  | 	/usr/local/go/src/runtime/asm_amd64.s:1357
		Wraps: (4) monitor task failed
		Wraps: (5) dial tcp 34.70.108.130:26257
		Wraps: (6) connect
		Wraps: (7) connection refused
		Error types: (1) *withstack.withStack (2) *errutil.withMessage (3) *withstack.withStack (4) *errutil.withMessage (5) *net.OpError (6) *os.SyscallError (7) syscall.Errno

	cluster.go:1571,context.go:135,cluster.go:1560,test_runner.go:823: dead node detection: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/bin/roachprod monitor teamcity-2163421-1596954166-27-n4cpu16 --oneshot --ignore-empty-nodes: exit status 1 4: skipped
		3: 4374
		1: dead
		2: 4563
		Error: UNCLASSIFIED_PROBLEM: 1: dead
		(1) UNCLASSIFIED_PROBLEM
		Wraps: (2) attached stack trace
		  | main.glob..func13
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachprod/main.go:1115
		  | main.wrap.func1
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachprod/main.go:266
		  | github.com/spf13/cobra.(*Command).execute
		  | 	/home/agent/work/.go/pkg/mod/github.com/spf13/[email protected]/command.go:830
		  | github.com/spf13/cobra.(*Command).ExecuteC
		  | 	/home/agent/work/.go/pkg/mod/github.com/spf13/[email protected]/command.go:914
		  | github.com/spf13/cobra.(*Command).Execute
		  | 	/home/agent/work/.go/pkg/mod/github.com/spf13/[email protected]/command.go:864
		  | main.main
		  | 	/home/agent/work/.go/src/github.com/cockroachdb/cockroach/pkg/cmd/roachprod/main.go:1808
		  | runtime.main
		  | 	/usr/local/go/src/runtime/proc.go:203
		  | runtime.goexit
		  | 	/usr/local/go/src/runtime/asm_amd64.s:1357
		Wraps: (3) 3 safe details enclosed
		Wraps: (4) 1: dead
		Error types: (1) errors.Unclassified (2) *withstack.withStack (3) *safedetails.withSafeDetails (4) *errors.errorString
More

Artifacts: /cdc/tpcc-1000/rangefeed=true
Related:

See this test on roachdash
powered by pkg/cmd/internal/issues
@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. labels Aug 9, 2020
@cockroach-teamcity cockroach-teamcity added this to the 20.2 milestone Aug 9, 2020
@cockroach-teamcity
Copy link
Member Author

(roachtest).cdc/tpcc-1000 failed on master@d106b79cb3838bbc1fb163e8d8216488130b521e:

The test failed on branch=master, cloud=gce:
test artifacts and logs in: /home/agent/work/.go/src/github.com/cockroachdb/cockroach/artifacts/cdc/tpcc-1000/run_1
	cdc.go:69,cdc.go:496,test_runner.go:754: pq: unknown cluster setting 'changefeed.push.enabled'
More

Artifacts: /cdc/tpcc-1000
Related:

See this test on roachdash
powered by pkg/cmd/internal/issues

@cockroach-teamcity cockroach-teamcity mentioned this issue Aug 16, 2020
Closed
@nvanbenschoten nvanbenschoten mentioned this issue Aug 17, 2020
Merged
craig bot pushed a commit that referenced this issue Aug 18, 2020
@nvanbenschoten
Merge #52928
22a31b6 
52928: roachtest: don't set changefeed.push.enabled r=nvanbenschoten a=nvanbenschoten

Fixes #52875.
Fixes #52874.
Fixes #52873.
Fixes #52872.
Fixes #52871.
Fixes #52870.
Fixes #52856.
Fixes #52855.
Fixes #52854.
Fixes #52853.
Fixes #52852.
Fixes #52544.

In 8a81eac, we stopped ignoring "unknown cluster setting" errors when setting `changefeed.push.enabled` in a number of cdc tests. The comment on the code mentioned v2.1, but it turns out that it was also saving us on v19.2 onward because this cluster setting was removed in v19.2 in c7a195c.

We can remove the code to set the cluster setting entirely. It's dead code when testing v19.2 onward, and the cluster setting defaults to [`true` in v19.1](https://github.com/cockroachdb/cockroach/blob/cebc92d5ad596d721382df9ef18fac2ded589547/pkg/ccl/changefeedccl/changefeed.go#L48).


Co-authored-by: Nathan VanBenschoten <[email protected]>
@craig craig bot closed this as completed in 169aad5 Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked.
Projects
None yet
Milestone
20.2
Development

Successfully merging a pull request may close this issue.

roachtest: don't set changefeed.push.enabled nvanbenschoten/cockroach
1 participant
@cockroach-teamcity