partitionccl: error instead of panic for an invalid partitioning #37689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a PARTITION BY LIST both didn't match the column names in the index being partitioned and also tried to partition by more columns than were in the index, we previously panic'd when constructing the error. Closes cockroachdb#37682 Release note (bug fix): Fixed a panic when construting the error message for an invalid partitioning.
|
This change is |
justinj
reviewed
May 21, 2019
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @jordanlewis and @justinj)
|
TFTRs! bors r=justinj,jordanlewis |
craig bot
pushed a commit
that referenced
this pull request
May 21, 2019
37673: roachtest: skip kv/gracefuldraining r=nvanbenschoten a=tbg I should've done this a long time ago, it's been flaky for five months and failed approximately 120 times (i.e. most of the time). See #33501 (comment) Release note: None 37689: partitionccl: error instead of panic for an invalid partitioning r=justinj,jordanlewis a=danhhz If a PARTITION BY LIST both didn't match the column names in the index being partitioned and also tried to partition by more columns than were in the index, we previously panic'd when constructing the error. Closes #37682 Release note (bug fix): Fixed a panic when construting the error message for an invalid partitioning. Co-authored-by: Tobias Schottdorf <[email protected]> Co-authored-by: Daniel Harrison <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a PARTITION BY LIST both didn't match the column names in the index
being partitioned and also tried to partition by more columns than were
in the index, we previously panic'd when constructing the error.
Closes #37682
Release note (bug fix): Fixed a panic when construting the error message
for an invalid partitioning.