sentry: conn_executor.go:647: panic while executing 1 statements: CREATE TABLE _ (_ STRING(20), _ INT8, _ INT8, _ STRING(20)) PARTITION BY LIST (_, _) (PARTITION _ VALUES IN (_), PARTITION _ VALUES IN (_), PARTITION _ VALUES IN (_), PARTITION _ VALUES IN (DEFAULT)): caused by <redacted>

[cockroach-teamcity]

This issue was autofiled by Sentry. It represents a crash or reported error on a live cluster with telemetry enabled.

Sentry link: https://sentry.io/organizations/cockroach-labs/issues/1036314618/?referrer=webhooks_plugin

Panic message:

conn_executor.go:647: panic while executing 1 statements: CREATE TABLE _ (_ STRING(20), _ INT8, _ INT8, _ STRING(20)) PARTITION BY LIST (, ) (PARTITION _ VALUES IN (), PARTITION _ VALUES IN (), PARTITION _ VALUES IN (_), PARTITION _ VALUES IN (DEFAULT)): caused by

Stacktrace (expand for inline code snippets):

cockroach/pkg/sql/conn_executor.go

Lines 388 to 390 in d554884

	r := recover()
	h.ex.closeWrapper(ctx, r)
	}()

in pkg/sql.(*Server).ServeConn.func1
/usr/local/go/src/runtime/asm_amd64.s#L572-L574 in runtime.call32
/usr/local/go/src/runtime/panic.go#L501-L503 in runtime.gopanic
/usr/local/go/src/runtime/panic.go#L34-L36 in runtime.panicslice

cockroach/pkg/ccl/partitionccl/partition.go

Lines 154 to 156 in d554884

	"declared partition columns (%s) do not match first %d columns in index being partitioned (%s)",
	partitioningString(), n, strings.Join(indexDesc.ColumnNames[:n], ", "))
	}

in pkg/ccl/partitionccl.createPartitioningImpl

cockroach/pkg/ccl/partitionccl/partition.go

Lines 226 to 228 in d554884

	return createPartitioningImpl(
	ctx, evalCtx, tableDesc, indexDesc, partBy, 0 /* colOffset */)

in pkg/ccl/partitionccl.createPartitioning

cockroach/pkg/sql/create_table.go

Lines 814 to 816 in d554884

	}
	return CreatePartitioningCCL(ctx, st, evalCtx, tableDesc, indexDesc, partBy)
	}

in pkg/sql.CreatePartitioning

cockroach/pkg/sql/create_table.go

Lines 1125 to 1127 in d554884

	if n.PartitionBy != nil {
	partitioning, err := CreatePartitioning(
	ctx, st, evalCtx, &desc, &desc.PrimaryIndex, n.PartitionBy)

in pkg/sql.MakeTableDesc

cockroach/pkg/sql/create_table.go

Lines 1236 to 1238 in d554884

	params.p.runWithOptions(resolveFlags{skipCache: true}, func() {
	ret, err = MakeTableDesc(
	params.ctx,

in pkg/sql.makeTableDesc.func2

cockroach/pkg/sql/resolver.go

Lines 139 to 141 in d554884

	}
	fn()
	}

in pkg/sql.(*planner).runWithOptions

cockroach/pkg/sql/create_table.go

Lines 1235 to 1237 in d554884

	// See the comment at the start of MakeTableDesc() and resolveFK().
	params.p.runWithOptions(resolveFlags{skipCache: true}, func() {
	ret, err = MakeTableDesc(

in pkg/sql.makeTableDesc

cockroach/pkg/sql/create_table.go

Lines 141 to 143 in d554884

	affected = make(map[sqlbase.ID]*sqlbase.TableDescriptor)
	desc, err = makeTableDesc(params, n.n, n.dbDesc.ID, id, creationTime, privs, affected)
	}

in pkg/sql.(*createTableNode).startExec

cockroach/pkg/sql/plan.go

Lines 639 to 641 in d554884

	if s, ok := n.(execStartable); ok {
	return s.startExec(params)
	}

in pkg/sql.startExec.func2

cockroach/pkg/sql/walk.go

Lines 133 to 135 in d554884

	}
	v.err = v.observer.leaveNode(name, plan)
	}()

in pkg/sql.(*planVisitor).visitInternal.func1

cockroach/pkg/sql/walk.go

Lines 542 to 544 in d554884

	}
	}

in pkg/sql.(*planVisitor).visitInternal

cockroach/pkg/sql/walk.go

Lines 100 to 102 in d554884

	}
	v.visitInternal(plan, name)
	return plan

in pkg/sql.(*planVisitor).visit

cockroach/pkg/sql/walk.go

Lines 64 to 66 in d554884

	v := makePlanVisitor(ctx, observer)
	v.visit(plan)
	return v.err

in pkg/sql.walkPlan

cockroach/pkg/sql/plan.go

Lines 644 to 646 in d554884

	}
	return walkPlan(params.ctx, plan, o)
	}

in pkg/sql.startExec

cockroach/pkg/sql/plan_node_to_row_source.go

Lines 122 to 124 in d554884

	// This starts all of the nodes below this node.
	if err := startExec(p.params, p.node); err != nil {
	p.MoveToDraining(err)

in pkg/sql.(*planNodeToRowSource).Start

cockroach/pkg/sql/distsqlrun/processors.go

Lines 729 to 731 in d554884

	}
	ctx = pb.self.Start(ctx)
	Run(ctx, pb.self, pb.out.output)

in pkg/sql/distsqlrun.(*ProcessorBase).Run

cockroach/pkg/sql/distsqlrun/flow.go

Lines 580 to 582 in d554884

	if len(f.processors) > 0 {
	f.processors[len(f.processors)-1].Run(ctx, nil)
	}

in pkg/sql/distsqlrun.(*Flow).StartSync

cockroach/pkg/sql/distsql_running.go

Lines 252 to 254 in d554884

	// TODO(radu): this should go through the flow scheduler.
	if err := flow.StartSync(ctx, func() {}); err != nil {
	log.Fatalf(ctx, "unexpected error from syncFlow.Start(): %s "+

in pkg/sql.(*DistSQLPlanner).Run

cockroach/pkg/sql/distsql_running.go

Lines 755 to 757 in d554884

	dsp.FinalizePlan(planCtx, &physPlan)
	dsp.Run(planCtx, txn, &physPlan, recv, evalCtx, nil /* finishedSetupFn */)
	}

in pkg/sql.(*DistSQLPlanner).PlanAndRun

cockroach/pkg/sql/conn_executor_exec.go

Lines 970 to 972 in d554884

	// the planner whether or not to plan remote table readers.
	ex.server.cfg.DistSQLPlanner.PlanAndRun(
	ctx, evalCtx, &planCtx, planner.txn, planner.curPlan.plan, recv)

in pkg/sql.(*connExecutor).execWithDistSQLEngine

cockroach/pkg/sql/conn_executor_exec.go

Lines 817 to 819 in d554884

	ex.sessionTracing.TraceExecStart(ctx, "distributed")
	err = ex.execWithDistSQLEngine(ctx, planner, stmt.AST.StatementType(), res, distributePlan)
	} else {

in pkg/sql.(*connExecutor).dispatchToExecutionEngine

cockroach/pkg/sql/conn_executor_exec.go

Lines 395 to 397 in d554884

	p.autoCommit = os.ImplicitTxn.Get() && !ex.server.cfg.TestingKnobs.DisableAutoCommit
	if err := ex.dispatchToExecutionEngine(ctx, stmt, p, res); err != nil {
	return nil, nil, err

in pkg/sql.(*connExecutor).execStmtInOpenState

cockroach/pkg/sql/conn_executor_exec.go

Lines 95 to 97 in d554884

	case stateOpen:
	ev, payload, err = ex.execStmtInOpenState(ctx, stmt, pinfo, res)
	switch ev.(type) {

in pkg/sql.(*connExecutor).execStmt

cockroach/pkg/sql/conn_executor.go

Lines 1122 to 1124 in d554884

	stmtCtx := withStatement(ex.Ctx(), ex.curStmt)
	ev, payload, err = ex.execStmt(stmtCtx, curStmt, stmtRes, nil /* pinfo */, pos)
	if err != nil {

in pkg/sql.(*connExecutor).run

cockroach/pkg/sql/conn_executor.go

Lines 390 to 392 in d554884

	}()
	return h.ex.run(ctx, s.pool, reserved, cancel)
	}

in pkg/sql.(*Server).ServeConn

cockroach/pkg/sql/pgwire/conn.go

Lines 519 to 521 in d554884

	reservedOwned = false // We're about to pass ownership away.
	retErr = sqlServer.ServeConn(ctx, connHandler, reserved, cancelConn)
	}()

in pkg/sql/pgwire.(*conn).processCommandsAsync.func1

pkg/sql/conn_executor.go in pkg/sql.(*Server).ServeConn.func1 at line 389
/usr/local/go/src/runtime/asm_amd64.s in runtime.call32 at line 573
/usr/local/go/src/runtime/panic.go in runtime.gopanic at line 502
/usr/local/go/src/runtime/panic.go in runtime.panicslice at line 35
pkg/ccl/partitionccl/partition.go in pkg/ccl/partitionccl.createPartitioningImpl at line 155
pkg/ccl/partitionccl/partition.go in pkg/ccl/partitionccl.createPartitioning at line 227
pkg/sql/create_table.go in pkg/sql.CreatePartitioning at line 815
pkg/sql/create_table.go in pkg/sql.MakeTableDesc at line 1126
pkg/sql/create_table.go in pkg/sql.makeTableDesc.func2 at line 1237
pkg/sql/resolver.go in pkg/sql.(*planner).runWithOptions at line 140
pkg/sql/create_table.go in pkg/sql.makeTableDesc at line 1236
pkg/sql/create_table.go in pkg/sql.(*createTableNode).startExec at line 142
pkg/sql/plan.go in pkg/sql.startExec.func2 at line 640
pkg/sql/walk.go in pkg/sql.(*planVisitor).visitInternal.func1 at line 134
pkg/sql/walk.go in pkg/sql.(*planVisitor).visitInternal at line 543
pkg/sql/walk.go in pkg/sql.(*planVisitor).visit at line 101
pkg/sql/walk.go in pkg/sql.walkPlan at line 65
pkg/sql/plan.go in pkg/sql.startExec at line 645
pkg/sql/plan_node_to_row_source.go in pkg/sql.(*planNodeToRowSource).Start at line 123
pkg/sql/distsqlrun/processors.go in pkg/sql/distsqlrun.(*ProcessorBase).Run at line 730
pkg/sql/distsqlrun/flow.go in pkg/sql/distsqlrun.(*Flow).StartSync at line 581
pkg/sql/distsql_running.go in pkg/sql.(*DistSQLPlanner).Run at line 253
pkg/sql/distsql_running.go in pkg/sql.(*DistSQLPlanner).PlanAndRun at line 756
pkg/sql/conn_executor_exec.go in pkg/sql.(*connExecutor).execWithDistSQLEngine at line 971
pkg/sql/conn_executor_exec.go in pkg/sql.(*connExecutor).dispatchToExecutionEngine at line 818
pkg/sql/conn_executor_exec.go in pkg/sql.(*connExecutor).execStmtInOpenState at line 396
pkg/sql/conn_executor_exec.go in pkg/sql.(*connExecutor).execStmt at line 96
pkg/sql/conn_executor.go in pkg/sql.(*connExecutor).run at line 1123
pkg/sql/conn_executor.go in pkg/sql.(*Server).ServeConn at line 391
pkg/sql/pgwire/conn.go in pkg/sql/pgwire.(*conn).processCommandsAsync.func1 at line 520

Tag	Value
Cockroach Release	v2.1.7
Cockroach SHA:	d554884
Platform	darwin amd64
Distribution	CCL
Environment	v2.1.7
Command	demo
Go Version	go1.10.7
# of CPUs	8
# of Goroutines	168

[justinj]

Repro:

create table x (a int default 12, b int default 34) partition by list (a, b) (partition p1 values in ((1,2)), partition default values in (default));

[danhhz]

Justin's repro seems to panic on strings.Join(indexDesc.ColumnNames[:n], ", ")) on line

cockroach/pkg/ccl/partitionccl/partition.go

Lines 182 to 184 in cb13780

	return partDesc, pgerror.Newf(pgerror.CodeSyntaxError,
	"declared partition columns (%s) do not match first %d columns in index being partitioned (%s)",
	partitioningString(), n, strings.Join(indexDesc.ColumnNames[:n], ", "))

[danhhz]

Yeah, looks like the repro conditions are 1) trying to partition with more columns than there are in the primary key (or other index being partitioned and 2) one of the columns names doesn't match. I think reversing the "sufficient columns" check and the "column names match" check should fix it

[danhhz]

Right diagnosis, wrong fix. PR incoming

[danhhz]

Bravo on the simple repro @justinj, that was extremely helpful