Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug about crash issure when partition created with sub-partition #38390

Closed
wants to merge 1 commit into from
Closed

fix bug about crash issure when partition created with sub-partition #38390

wants to merge 1 commit into from

Conversation

leafji
Copy link

@leafji leafji commented Jun 25, 2019

this is a fix about issue #38389, it will meet a crash issue when create stmt as below:
create table st1(id string, name string, primary key(id, name))
partition by list(id) (
partition p1 values in ('us')
partition by list(id, name)(
partition p11 values in('la')))

the root reason is an overflow visit of index-column array.

Fixes #38389

Release note (sql change): fix bug

this is a fix about issue #38389, it will meet a crash issue when create stmt as below:
create table st1(id string, name string, primary key(id, name))
partition by list(id) (
partition p1 values in ('us')
partition by list(id, name)(
partition p11 values in('la')))

the root reason is an overflow visit of index-column array.

Fixes #38389

Release note (sql change): fix bug
@leafji leafji requested a review from a team June 25, 2019 03:18
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@jordanlewis jordanlewis requested a review from a team June 25, 2019 13:46
@solongordon solongordon self-requested a review June 25, 2019 13:49
@solongordon
Copy link
Contributor

Thank you for the PR, but this was already fixed by #37689.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants