Broken index details link for drop unused indexes #92944
Assignees
Labels
C-bug
Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Comments
kevin-v-ngo
added
the
C-bug
maryliag
added a commit
to maryliag/cockroach
that referenced
this issue
Dec 2, 2022
Previously, the link to index details on the drop index insights was using the URL format used by DB Console only. This commit updates to use the correct format when loading from CC Console. Fix cockroachdb#92944 Release note (bug fix): Fix link to index details on drop index insights on CC Console.
maryliag
added a commit
to maryliag/cockroach
that referenced
this issue
Dec 2, 2022
Previously, the link to index details on the drop index insights was using the URL format used by DB Console only. This commit updates to use the correct format when loading from CC Console. Fix cockroachdb#92944 Release note (bug fix): Fix link to index details on drop index insights on CC Console.
craig bot
pushed a commit
that referenced
this issue
Dec 2, 2022
88219: {bazci,dev}: send build events to beaver hub r=rickystewart a=healthy-pod
This code change lets `bazci` and `dev` send build events to beaver hub so
we can start collecting data about builds in CI and locally.
Release note: None
Epic: [CRDB-8350](https://cockroachlabs.atlassian.net/browse/CRDB-8350)
92263: sql,cli: add redacted sql stmts to debug zip r=xinhaoz a=xinhaoz
## Commit 1
This commit adds the builtin, `crdb_internal.anonymize_sql_constants`
which takes in a sql string and returns it with constants redacted.
This will be used to redact columns that are sql stmts in the
redacted debug zip.
Release note: None
## Commit 2
Closes #88823
This commit adds the following fields to the redacted
debug zip:
crdb_internal.create_statements:
- create_statement
- - create_nofks
- alter_statements (each elem is redacted)
crdb_internal.create_function_statements:
- create_statement
crdb_internal.{node,cluster}_distsql_flows:
- stmt
crdb_internal.{cluster,node}_sessions:
- last_active
- active_queries
crdb_internal.{cluster,node}_queries:
- query
Release note (cli change):
The following fields have been redacted and added to
the redacted debug zip:
crdb_internal.create_statements:
- create_statement
- create_nofks
- alter_statements (each elem is redacted)
crdb_internal.create_function_statements:
- create_statement
-
crdb_internal.{node,cluster}_distsql_flows:
- stmt
crdb_internal.{cluster,node}_sessions:
- last_active
- active_queries
crdb_internal.{cluster,node}_queries:
- query
-----------
Running ycsb, tpcc and movr default workloads for 15 minutes and requesting the debug zip on a fresh node in master vs with new changes:
master
<img width="927" alt="Pasted Graphic" src="https://user-images.githubusercontent.com/20136951/203359099-6a035d1c-00fe-4bbb-92c2-d1c2b2a3b706.png">
branch
<img width="978" alt="Pasted Graphic 2" src="https://user-images.githubusercontent.com/20136951/203359158-a8b02ccb-2d82-40b4-a33d-9faf6ddaab70.png">
92627: leaktest, stop: don't recover from panics r=andreimatei a=andreimatei
See individual commits.
Epic: None
92793: roachtest: update activerecord blocklist and ignore list r=ZhouXing19,rafiss a=andyyang890
This patch updates the blocklist and ignore list for the
activerecord roachtest. This patch also eliminates the
per-version lists since each release branch uses their
own list now.
Fixes #84955
Release note: None
92856: log: fix flakiness in TestStatusLogRedaction r=dhartunian a=abarganier
TestStatusLogRedaction was continuously failing when run with `--race`.
The test searches for a specific log line in the results from two separate RPCs - `LogFile()` and `Log()`. The test consistently failed when checking the results from the `Log()` RPC because the endpoint has a default max number of log entries set to 1000. Frequently, the log entry that we're searching for has a line index in the range of [1500, 2000], so the test was failing to find the log entry since it was being filtered out due to the default max number of entries.
This patch simply sets the max to a high enough value where this should no longer happen. With multiple runs I never saw the total # of log lines exceed 2,500, so we set the max to 5,000 to be safe.
Release note: None
Fixes: #92789
92929: rttanalysis: skip test which doesn't work due to tracing limitations r=ajwerner a=ajwerner
This test ends up not seeing all the round trips because the trace is way too large. Given that, we get flakes sometimes. See the referenced issue (#88885).
Fixes #92770
Release note: None
92934: clisqlshell: fix a panic on tab key r=rail a=knz
Fixes #92935.
This patch ensures that there's no visible panic if the user presses "tab" and there's no completion available.
NB: no unit tests here - the test coverage will be delivered by #87606.
92942: kvserver: remove the assertion on not exceeding MaxSpanRequestKeys r=yuzefovich a=yuzefovich
This commit fixes the bug in a recently merged commit where we allowed to exceed `MaxSpanRequestKeys` in some cases - we forgot to update the remaining limit to be "exhausted". Furthermore, this commit removes the assertion altogether.
Epic: None
Release note: None
92953: ui: fix link for index from insights r=maryliag a=maryliag
Previously, the link to index details on the
drop index insights was using the URL format used by DB Console only. This commit updates to use the correct format when loading from CC Console.
Fix #92944
Release note (bug fix): Fix link to index details on drop index insights on CC Console.
Co-authored-by: healthy-pod <[email protected]>
Co-authored-by: Xin Hao Zhang <[email protected]>
Co-authored-by: Andrei Matei <[email protected]>
Co-authored-by: Andy Yang <[email protected]>
Co-authored-by: Alex Barganier <[email protected]>
Co-authored-by: Andrew Werner <[email protected]>
Co-authored-by: Raphael 'kena' Poss <[email protected]>
Co-authored-by: Yahor Yuzefovich <[email protected]>
Co-authored-by: maryliag <[email protected]>
maryliag
added a commit
to maryliag/cockroach
that referenced
this issue
Dec 5, 2022
Previously, the link to index details on the drop index insights was using the URL format used by DB Console only. This commit updates to use the correct format when loading from CC Console. Fix cockroachdb#92944 Release note (bug fix): Fix link to index details on drop index insights on CC Console.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Clicking on an index for the drop unused index recommendation takes the user to the cluster overview page - not the index details page on 22.2.
Jira issue: CRDB-22062
The text was updated successfully, but these errors were encountered: