Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: update activerecord blocklist and ignore list #92793

Merged
merged 1 commit into from
Dec 2, 2022

Conversation

andyyang890
Copy link
Collaborator

@andyyang890 andyyang890 commented Dec 1, 2022

This patch updates the blocklist and ignore list for the
activerecord roachtest. This patch also eliminates the
per-version lists since each release branch uses their
own list now.

Fixes #84955

Release note: None

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@andyyang890 andyyang890 force-pushed the activerecord_roachtest branch 4 times, most recently from 56c6c99 to 8da6101 Compare December 2, 2022 03:07
@andyyang890 andyyang890 requested review from rafiss and a team December 2, 2022 03:17
@andyyang890 andyyang890 force-pushed the activerecord_roachtest branch 2 times, most recently from d97e1c4 to a13ea0b Compare December 2, 2022 17:48
@andyyang890 andyyang890 marked this pull request as ready for review December 2, 2022 17:54
Copy link
Collaborator

@ZhouXing19 ZhouXing19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andyyang890 andyyang890 force-pushed the activerecord_roachtest branch from a13ea0b to 468c1ea Compare December 2, 2022 21:56
@rafiss
Copy link
Collaborator

rafiss commented Dec 2, 2022

lgtm, thanks for these updates!

@andyyang890
Copy link
Collaborator Author

TFTRs!

bors r=ZhouXing19,rafiss

This patch updates the blocklist and ignore list for the
activerecord roachtest. This patch also eliminates the
per-version lists since each release branch uses their
own list now.

Release note: None
@andyyang890 andyyang890 force-pushed the activerecord_roachtest branch from 468c1ea to 3dc103d Compare December 2, 2022 22:17
@craig
Copy link
Contributor

craig bot commented Dec 2, 2022

Canceled.

@andyyang890
Copy link
Collaborator Author

Fixed a few typos

bors r=ZhouXing19,rafiss

@craig craig bot merged commit 865ad56 into cockroachdb:master Dec 2, 2022
@craig
Copy link
Contributor

craig bot commented Dec 2, 2022

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

roachtest: activerecord failed
4 participants