Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: update activerecord blocklist and ignore list #92793

Merged
merged 1 commit into from
Dec 2, 2022
Merged

roachtest: update activerecord blocklist and ignore list #92793

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 6 additions & 12 deletions pkg/cmd/roachtest/tests/activerecord.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,15 +164,9 @@ func registerActiveRecord(r registry.Registry) {
t.Fatal(err)
}

blocklistName, expectedFailures, ignorelistName, ignorelist := activeRecordBlocklists.getLists(version)
if expectedFailures == nil {
t.Fatalf("No activerecord blocklist defined for cockroach version %s", version)
}
status := fmt.Sprintf("Running cockroach version %s, using blocklist %s", version, blocklistName)
if ignorelist != nil {
status = fmt.Sprintf("Running cockroach version %s, using blocklist %s, using ignorelist %s",
version, blocklistName, ignorelistName)
}
blocklistName, ignorelistName := "activeRecordBlocklist", "activeRecordIgnoreList"
status := fmt.Sprintf("Running cockroach version %s, using blocklist %s, using ignorelist %s",
version, blocklistName, ignorelistName)
t.L().Printf("%s", status)

t.Status("running activerecord test suite")
Expand Down Expand Up @@ -206,8 +200,8 @@ func registerActiveRecord(r registry.Registry) {
skipped := result == "S"
results.allTests = append(results.allTests, test)

ignoredIssue, expectedIgnored := ignorelist[test]
issue, expectedFailure := expectedFailures[test]
ignoredIssue, expectedIgnored := activeRecordIgnoreList[test]
issue, expectedFailure := activeRecordBlocklist[test]
switch {
case expectedIgnored:
results.results[test] = fmt.Sprintf("--- SKIP: %s due to %s (expected)", test, ignoredIssue)
Expand Down Expand Up @@ -241,7 +235,7 @@ func registerActiveRecord(r registry.Registry) {
}

results.summarizeAll(
t, "activerecord" /* ormName */, blocklistName, expectedFailures, version, supportedRailsVersion,
t, "activerecord" /* ormName */, blocklistName, activeRecordBlocklist, version, supportedRailsVersion,
)
}

Expand Down
124 changes: 70 additions & 54 deletions pkg/cmd/roachtest/tests/activerecord_blocklist.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,6 @@

package tests

var activeRecordBlocklists = blocklistsForVersion{
{"v20.2", "activeRecordBlockList20_2", activeRecordBlockList20_2, "activeRecordIgnoreList20_2", activeRecordIgnoreList20_2},
{"v21.1", "activeRecordBlockList21_1", activeRecordBlockList21_1, "activeRecordIgnoreList21_1", activeRecordIgnoreList21_1},
{"v21.2", "activeRecordBlockList21_2", activeRecordBlockList21_2, "activeRecordIgnoreList21_2", activeRecordIgnoreList21_2},
{"v22.1", "activeRecordBlockList22_1", activeRecordBlockList22_1, "activeRecordIgnoreList22_1", activeRecordIgnoreList22_1},
{"v22.2", "activeRecordBlockList22_2", activeRecordBlockList22_2, "activeRecordIgnoreList22_2", activeRecordIgnoreList22_2},
{"v23.1", "activeRecordBlockList23_1", activeRecordBlockList23_1, "activeRecordIgnoreList23_1", activeRecordIgnoreList23_1},
}

// These are lists of known activerecord test errors and failures.
// When the activerecord test suite is run, the results are compared to this list.
// Any passed test that is not on this list is reported as PASS - expected
Expand All @@ -30,51 +21,76 @@ var activeRecordBlocklists = blocklistsForVersion{
// Please keep these lists alphabetized for easy diffing.
// After a failed run, an updated version of this blocklist should be available
// in the test log.
var activeRecordBlockList23_1 = blocklist{}

var activeRecordBlockList22_2 = blocklist{}

var activeRecordBlockList22_1 = blocklist{}

var activeRecordBlockList21_2 = blocklist{}

var activeRecordBlockList21_1 = blocklist{}

var activeRecordBlockList20_2 = blocklist{}

var activeRecordIgnoreList23_1 = activeRecordIgnoreList22_2

var activeRecordIgnoreList22_2 = activeRecordIgnoreList22_1

var activeRecordIgnoreList22_1 = blocklist{
"CockroachDB::PostgresqlIntervalTest#test_interval_type": "flaky",
"ConcurrentTransactionTest#test_transaction_isolation__read_committed": "flaky - https://github.com/cockroachdb/activerecord-cockroachdb-adapter/issues/237",
"FixturesTest#test_create_fixtures": "flaky - FK constraint violated sometimes when loading all fixture data",
"IgnoreFixturesTest#test_ignores_books_fixtures": "flaky - FK constraint violated sometimes when loading all fixture data",
"IgnoreFixturesTest#test_ignores_parrots_fixtures": "flaky - FK constraint violated sometimes when loading all fixture data",
"PostgresqlIntervalTest#test_interval_type": "flaky",
}

var activeRecordIgnoreList21_2 = blocklist{
"ActiveRecord::CockroachDB::UnloggedTablesTest#test_gracefully_handles_temporary_tables": "modified to pass on 20.2",
"CockroachDB::PostgresqlIntervalTest#test_interval_type": "flaky",
"ConcurrentTransactionTest#test_transaction_isolation__read_committed": "flaky - https://github.com/cockroachdb/activerecord-cockroachdb-adapter/issues/237",
"FixturesTest#test_create_fixtures": "flaky - FK constraint violated sometimes when loading all fixture data",
"IgnoreFixturesTest#test_ignores_books_fixtures": "flaky - FK constraint violated sometimes when loading all fixture data",
"IgnoreFixturesTest#test_ignores_parrots_fixtures": "flaky - FK constraint violated sometimes when loading all fixture data",
}

var activeRecordIgnoreList21_1 = blocklist{
"ActiveRecord::CockroachDB::UnloggedTablesTest#test_gracefully_handles_temporary_tables": "modified to pass on 20.2",
"CockroachDB::PostgresqlIntervalTest#test_interval_type": "flaky",
"FixturesTest#test_create_fixtures": "flaky - FK constraint violated sometimes when loading all fixture data",
"IgnoreFixturesTest#test_ignores_books_fixtures": "flaky - FK constraint violated sometimes when loading all fixture data",
"IgnoreFixturesTest#test_ignores_parrots_fixtures": "flaky - FK constraint violated sometimes when loading all fixture data",
var activeRecordBlocklist = blocklist{
andyyang890 marked this conversation as resolved.
Show resolved Hide resolved
"ActiveRecord::CockroachDB::Migration::PGChangeSchemaTest#test_change_string_to_date": "49329",
"ActiveRecord::CockroachDB::Migration::PGChangeSchemaTest#test_change_type_with_array": "49329",
"ActiveRecord::CockroachDB::Migration::PGChangeSchemaTest#test_change_type_with_symbol": "49329",
"ActiveRecord::CockroachDB::Migration::PGChangeSchemaTest#test_change_type_with_symbol_using_datetime": "49329",
"ActiveRecord::CockroachDB::Migration::PGChangeSchemaTest#test_change_type_with_symbol_using_datetime_with_timestamptz_as_default": "49329",
"ActiveRecord::CockroachDB::Migration::PGChangeSchemaTest#test_change_type_with_symbol_using_timestamp_with_timestamptz_as_default": "49329",
"ActiveRecord::CockroachDB::Migration::PGChangeSchemaTest#test_change_type_with_symbol_with_timestamptz_as_default": "49329",
"ActiveRecord::CockroachDB::Migration::PGChangeSchemaTest#test_change_type_with_symbol_with_timestamptz": "49329",
"PostgresqlRangeTest#test_timezone_array_awareness_tsrange": "27791",
"PostgresqlRangeTest#test_timezone_array_awareness_tzrange": "27791",
// TODO(yang): investigate cause further
"PostgreSQLReferentialIntegrityTest#test_all_foreign_keys_valid_having_foreign_keys_in_multiple_schemas": "unknown",
"PostgresqlTimestampWithAwareTypesTest#test_timestamp_with_zone_values_with_rails_time_zone_support_and_time_zone_set": "expected ActiveSupport::TimeWithZone, not Time",
"PostgresqlTimestampWithTimeZoneTest#test_timestamp_with_zone_values_with_rails_time_zone_support_and_timestamptz_and_time_zone_set": "expected ActiveSupport::TimeWithZone, not Time",
}

var activeRecordIgnoreList20_2 = blocklist{
"ActiveRecord::CockroachDB::UnloggedTablesTest#test_gracefully_handles_temporary_tables": "modified to pass on 20.2",
"FixturesTest#test_create_fixtures": "flaky - FK constraint violated sometimes when loading all fixture data",
"IgnoreFixturesTest#test_ignores_books_fixtures": "flaky - FK constraint violated sometimes when loading all fixture data",
"IgnoreFixturesTest#test_ignores_parrots_fixtures": "flaky - FK constraint violated sometimes when loading all fixture data",
var activeRecordIgnoreList = blocklist{
"ActiveRecord::Coders::YAMLColumnTestWithSafeLoad#test_returns_string_unless_starts_with_dash": "flaky - sometimes attempts to call a method on nil",
"ActiveRecord::ConnectionAdapters::ConnectionSwappingNestedTest#test_prevent_writes_can_be_changed_granularly": "flaky - sometimes attempts to call a method on nil",
"ActiveRecord::PostgresqlConnectionTest#test_table_exists_logs_name": "flaky - sometimes attempts to call a method on nil",
"ActiveRecord::WhereChainTest#test_chaining_multiple": "flaky - sometimes complains that a relation does not exist",
"BinaryTest#test_mixed_encoding": "flaky - sometimes complains that a relation does not exist",
"CockroachDB::FixturesTest#test_bulk_insert": "flaky",
"CockroachDB::PostgresqlIntervalTest#test_interval_type": "flaky",
"ConcurrentTransactionTest#test_transaction_isolation__read_committed": "flaky - https://github.com/cockroachdb/activerecord-cockroachdb-adapter/issues/237",
"DefaultTextTest#test_default_texts_containing_single_quotes": "flaky - sometimes complains that a relation does not exist",
"FixturesTest#test_create_fixtures": "flaky - FK constraint violated sometimes when loading all fixture data",
"FixturesTest#test_nonexistent_fixture_file": "flaky - sometimes complains that a relation does not exist",
"FixturesTest#test_subsubdir_file_with_arbitrary_name": "flaky - sometimes complains that a relation does not exist",
"FoxyFixturesTest#test_identifies_strings": "flaky - sometimes complains that a relation does not exist",
"FoxyFixturesTest#test_populates_timestamp_column": "flaky - sometimes complains that a relation does not exist",
"HasManyAssociationsTest#test_calling_empty_on_an_association_that_has_not_been_loaded_performs_a_query": "flaky - sometimes complains that a relation does not exist",
"HasManyAssociationsTest#test_calling_one_should_count_instead_of_loading_association": "flaky - sometimes complains that a relation does not exist",
"HasManyAssociationsTest#test_delete_on_association_clears_scope": "flaky - sometimes complains that a relation does not exist",
"HasManyAssociationsTest#test_deleting_before_save": "flaky - sometimes complains that a relation does not exist",
"HasManyAssociationsTest#test_destroy_all_on_association_clears_scope": "flaky - sometimes complains that a relation does not exist",
"HasManyAssociationsTest#test_destroying_by_string_id": "flaky - sometimes complains that a relation does not exist",
"HasManyAssociationsTest#test_get_ids_for_ordered_association": "flaky - sometimes complains that a relation does not exist",
"HasOneThroughAssociationsTest#test_has_one_through_do_not_cache_association_reader_if_the_though_method_has_default_scopes": "flaky - sometimes complains that a relation does not exist",
"HasOneThroughAssociationsTest#test_save_of_record_with_loaded_has_one_through": "flaky - sometimes complains that a relation does not exist",
"HasManyAssociationsTest#test_prevent_double_firing_the_before_save_callback_of_new_object_when_the_parent_association_saved_in_the_callback": "flaky - sometimes complains that a relation does not exist",
"HasManyAssociationsTest#test_transaction_when_deleting_persisted": "flaky - sometimes complains that a relation does not exist",
"HotCompatibilityTest#test_update_after_remove_column": "flaky - sometimes attempts to call a method on nil",
"InverseBelongsToTests#test_child_instance_should_be_shared_with_replaced_via_accessor_parent": "flaky - sometimes complains that a relation does not exist",
"InverseHasOneTests#test_parent_instance_should_be_shared_with_newly_built_child": "flaky - sometimes complains that a relation does not exist",
"IgnoreFixturesTest#test_ignores_books_fixtures": "flaky - FK constraint violated sometimes when loading all fixture data",
"IgnoreFixturesTest#test_ignores_parrots_fixtures": "flaky - FK constraint violated sometimes when loading all fixture data",
"JsonAttributeTest#test_select_array_json_value": "flaky - sometimes attempts to call a method on nil",
"LengthValidationTest#test_validates_size_of_association_using_within": "flaky - sometimes complains that a relation does not exist",
"PostgresqlInfinityTest#test_where_clause_with_infinite_range_on_a_datetime_column": "flaky - sometimes complains that a relation does not exist",
"PostgresqlIntervalTest#test_interval_type": "flaky",
"RelationTest#test_finding_last_with_arel_order": "flaky - sometimes complains that a relation does not exist",
"RelationTest#test_joins_with_select_custom_attribute": "flaky - sometimes complains that a relation does not exist",
"RelationTest#test_order_triggers_eager_loading_when_ordering_using_hash_syntax": "flaky - sometimes complains that a relation does not exist",
"RelationTest#test_select_takes_a_variable_list_of_args": "flaky - sometimes complains that a relation does not exist",
"RelationTest#test_size_with_limit": "flaky - sometimes complains that a relation does not exist",
"RelationTest#test_to_yaml": "flaky - sometimes complains that a relation does not exist",
"ReservedWordTest#test_calculations_work_with_reserved_words": "flaky - sometimes complains that a relation does not exist",
"StrictLoadingTest#test_raises_on_lazy_loading_a_strict_loading_belongs_to_relation": "flaky - sometimes complains that a relation does not exist",
"StrictLoadingTest#test_raises_on_unloaded_relation_methods_if_strict_loading": "flaky - sometimes complains that a relation does not exist",
"StrictLoadingTest#test_strict_loading_can_be_turned_off_on_an_association_in_a_model_with_strict_loading_on": "flaky - sometimes complains that a relation does not exist",
"StrictLoadingTest#test_strict_loading_with_reflection_is_ignored_in_validation_context": "flaky - sometimes complains that a relation does not exist",
"TestHasOneAutosaveAssociationWhichItselfHasAutosaveAssociations#test_when_great-grandchild_changed_in_memory,_saving_parent_should_save_great-grandchild": "flaky - sometimes attempts to call a method on nil",
"TimestampTest#test_changing_parent_of_a_record_touches_both_new_and_old_polymorphic_parent_record_changes_with_other_class": "flaky - sometimes complains that a relation does not exist",
"TimestampTest#test_timestamp_column_values_are_present_in_the_callbacks": "flaky - sometimes complains that a relation does not exist",
"TimestampTest#test_touching_update_at_attribute_as_symbol_updates_timestamp": "flaky - sometimes complains that a relation does not exist",
"TouchTest#test_create_turned_off": "flaky - sometimes complains that a relation does not exist",
"TouchTest#test_update": "flaky - sometimes complains that a relation does not exist",
"TransactionsWithTransactionalFixturesTest#test_no_automatic_savepoint_for_inner_transaction": "flaky - sometimes attempts to call a method on nil",
"TypeTest#test_registering_a_new_type": "flaky - sometimes attempts to call a method on nil",
"UniquenessValidationTest#test_validate_case_insensitive_uniqueness_with_special_sql_like_chars": "flaky - sometimes complains that a relation does not exist",
}
Loading