Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: TestStatusLogRedaction is flaky #92789

Closed
adityamaru opened this issue Dec 1, 2022 · 2 comments · Fixed by #92856
Closed

server: TestStatusLogRedaction is flaky #92789

adityamaru opened this issue Dec 1, 2022 · 2 comments · Fixed by #92856
Assignees
@abarganier
Labels
A-observability-inf C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.

Comments

@adityamaru
Copy link
Contributor

adityamaru commented Dec 1, 2022 •
edited by cockroach-jira-scripts
Loading

The test has pretty consistently been failing under race - https://teamcity.cockroachdb.com/project.html?projectId=Cockroach_Ci_Tests&testNameId=7224350708294769486&tab=testDetails

Jira issue: CRDB-21964
@adityamaru adityamaru added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-server-and-security DB Server & Security labels Dec 1, 2022
adityamaru added a commit to adityamaru/cockroach that referenced this issue Dec 1, 2022
@adityamaru
server: skip TestStatusLogRedaction under race
7a4f396 
Refs: cockroachdb#92789

Reason: flaky test

Generated by bin/skip-test.

Release justification: non-production code changes

Release note: None
@adityamaru adityamaru mentioned this issue Dec 1, 2022
Merged
@knz
Copy link
Contributor

knz commented Dec 1, 2022

cc @abarganier @dhartunian for triage

@abarganier
Copy link
Contributor

Thanks for the tag, we will take a look.

craig bot pushed a commit that referenced this issue Dec 1, 2022
@adityamaru
Merge #92790
2ac677c 
92790: server: skip TestStatusLogRedaction under race r=dhartunian a=adityamaru

Refs: #92789

Reason: flaky test

Generated by bin/skip-test.

Release justification: non-production code changes

Release note: None

Co-authored-by: adityamaru <[email protected]>
@abarganier abarganier mentioned this issue Dec 1, 2022
Merged
@craig craig bot closed this as completed in #92856 Dec 2, 2022
@craig craig bot closed this as completed in 865ad56 Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abarganier abarganier

Labels
A-observability-inf C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

log: fix flakiness in TestStatusLogRedaction abarganier/cockroach
3 participants
@knz @abarganier @adityamaru