Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: support row_to_json #37124

Closed
awoods187 opened this issue Apr 25, 2019 · 0 comments · Fixed by #38869
Closed

sql: support row_to_json #37124

awoods187 opened this issue Apr 25, 2019 · 0 comments · Fixed by #38869
Labels
A-sql-builtins SQL built-in functions and semantics thereof. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@awoods187
Copy link
Contributor

PGAdmin uses row_to_json underneath the hood (as obtained via vmodule=conn_executor=2 --logtostderr):

I190425 14:25:50.706016 2640 sql/conn_executor.go:1347  [n1,client=172.23.0.5:38720,user=root] execution error: unknown function: row_to_json()

https://www.postgresql.org/docs/9.5/functions-json.html
@BramGruneir BramGruneir mentioned this issue Apr 25, 2019
Open
@andreimatei andreimatei added the C-wishlist A wishlist feature. label May 1, 2019
@jordanlewis jordanlewis added good first issue C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-sql-builtins SQL built-in functions and semantics thereof. and removed C-wishlist A wishlist feature. good first issue labels Jul 13, 2019
@jordanlewis jordanlewis mentioned this issue Jul 19, 2019
Merged
craig bot pushed a commit that referenced this issue Jul 19, 2019
@jordanlewis
Merge #38869
7a6f5a9 
38869: sql: compatibility blitz for pgadmin r=jordanlewis a=jordanlewis

A bunch of small improvements to the catalog, new builtins, and a couple of typing improvements all in the name of making pgadmin work.

And it works okay now! Definitely still some flaws and unsupported things, but at least the default experience isn't completely broken anymore.

Closes #33341.
Closes #23299.
Closes #26389.
Closes #26378.
Closes #26390.
Closes #24747.
Closes #37124.
Updates #25213.

![image](https://user-images.githubusercontent.com/43821/61190353-f17fb980-a668-11e9-947f-d1bc3bb1e75d.png)

Co-authored-by: Jordan Lewis <[email protected]>
@craig craig bot closed this as completed in #38869 Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-sql-builtins SQL built-in functions and semantics thereof. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sql: compatibility blitz for pgadmin jordanlewis/cockroach
3 participants
@jordanlewis @andreimatei @awoods187