Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: support pg_matviews virtual table #24747

Closed
awoods187 opened this issue Apr 12, 2018 · 0 comments · Fixed by #38869
Closed

sql: support pg_matviews virtual table #24747

awoods187 opened this issue Apr 12, 2018 · 0 comments · Fixed by #38869
Labels
A-sql-pgcompat Semantic compatibility with PostgreSQL C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) X-anchored-telemetry The issue number is anchored by telemetry references.

Comments

@awoods187
Copy link
Contributor

An error pops up in Navicat when clicking materialized views:

v.ispopulated AS ispopulated, v.matviewowner AS mviewowner, v.definition AS definition, obj_description(c.oid) AS comment, t.spcname AS tablespace, v.schemaname AS schemaname 
FROM pg_matviews AS v 
INNER JOIN pg_class AS c ON v.matviewname = c.relname 
LEFT JOIN pg_tablespace AS t ON v.tablespace = t.spcname 
WHERE v.schemaname = 'public' 
ORDER BY v.matviewname ASC```

I180409 21:51:12.531915 380 sql/conn_executor.go:1805  [n1,client=[::1]:56172,user=root] execution error: relation "pg_matviews" does not exist

We don’t support materialized views at this time. 
@awoods187 awoods187 added the A-sql-pgcompat Semantic compatibility with PostgreSQL label Apr 12, 2018
@knz knz added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label May 2, 2018
@knz knz changed the title Support materialized views sql: support materialized views Jul 23, 2018
@knz knz added the X-anchored-telemetry The issue number is anchored by telemetry references. label Nov 22, 2018
@jordanlewis jordanlewis changed the title sql: support materialized views sql: support pg_matviews virtual table Jul 19, 2019
craig bot pushed a commit that referenced this issue Jul 19, 2019
38869: sql: compatibility blitz for pgadmin r=jordanlewis a=jordanlewis

A bunch of small improvements to the catalog, new builtins, and a couple of typing improvements all in the name of making pgadmin work.

And it works okay now! Definitely still some flaws and unsupported things, but at least the default experience isn't completely broken anymore.

Closes #33341.
Closes #23299.
Closes #26389.
Closes #26378.
Closes #26390.
Closes #24747.
Closes #37124.
Updates #25213.

![image](https://user-images.githubusercontent.com/43821/61190353-f17fb980-a668-11e9-947f-d1bc3bb1e75d.png)

Co-authored-by: Jordan Lewis <[email protected]>
@craig craig bot closed this as completed in #38869 Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-sql-pgcompat Semantic compatibility with PostgreSQL C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) X-anchored-telemetry The issue number is anchored by telemetry references.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants