Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: pgadmin support #25213

Open
18 of 25 tasks
Tracked by #25467
knz opened this issue May 1, 2018 · 3 comments
Open
18 of 25 tasks
Tracked by #25467

sql: pgadmin support #25213

knz opened this issue May 1, 2018 · 3 comments
Labels
A-sql-pgcompat Semantic compatibility with PostgreSQL C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) meta-issue Contains a list of several other issues. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@knz
Copy link
Contributor

knz commented May 1, 2018 •
edited by jordanlewis
Loading

An unfortunate new problem is that pgadmin has a hardcoded "last system OID" defined as 16383: https://github.com/pgadmin-org/pgadmin4/blob/master/web/pgadmin/utils/constants.py#L118

This constant is used as a filter to exclude databases and possibly other objects with IDs less than that number. There's no way that we can really configure this aside from forking pgadmin, and it doesn't fetch the number by querying the server, so we're a little stuck there.

List of issues encountered when running PGAdmin's test suite: #26603

Epic CRDB-2462

Jira issue: CRDB-5723
@knz knz added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-sql-pgcompat Semantic compatibility with PostgreSQL meta-issue Contains a list of several other issues. labels May 1, 2018
@knz
Copy link
Contributor Author

knz commented May 1, 2018

cc @awoods187 we'll look into this soon then

@BramGruneir BramGruneir mentioned this issue May 14, 2018
Open
4 tasks
@BramGruneir BramGruneir self-assigned this Jun 4, 2018
@jordanlewis jordanlewis mentioned this issue Jul 19, 2019
Merged
craig bot pushed a commit that referenced this issue Jul 19, 2019
@jordanlewis
Merge #38869
7a6f5a9 
38869: sql: compatibility blitz for pgadmin r=jordanlewis a=jordanlewis

A bunch of small improvements to the catalog, new builtins, and a couple of typing improvements all in the name of making pgadmin work.

And it works okay now! Definitely still some flaws and unsupported things, but at least the default experience isn't completely broken anymore.

Closes #33341.
Closes #23299.
Closes #26389.
Closes #26378.
Closes #26390.
Closes #24747.
Closes #37124.
Updates #25213.

![image](https://user-images.githubusercontent.com/43821/61190353-f17fb980-a668-11e9-947f-d1bc3bb1e75d.png)

Co-authored-by: Jordan Lewis <[email protected]>
@exalate-issue-sync exalate-issue-sync bot added the T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) label Jun 17, 2021
@jordanlewis jordanlewis mentioned this issue Nov 7, 2022
Closed
@codenoid
Copy link

hi, is there any update on this? It's almost 2024

@debankanmitra
Copy link

eagerly waiting for an update...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-sql-pgcompat Semantic compatibility with PostgreSQL C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) meta-issue Contains a list of several other issues. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@knz @BramGruneir @codenoid @debankanmitra