Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Metric For Cross Region Network RU Usage #108376

Closed
jeffswenson opened this issue Aug 8, 2023 · 0 comments · Fixed by #109290
Closed

Add Metric For Cross Region Network RU Usage #108376

jeffswenson opened this issue Aug 8, 2023 · 0 comments · Fixed by #109290
Assignees
Labels
A-multitenancy Related to multi-tenancy C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-serverless

Comments

@jeffswenson
Copy link
Collaborator

jeffswenson commented Aug 8, 2023

There are a handful of metrics exported by sql servers that track the source of RU consumption. We should add a metric that tracks the total cost of cross-region network traffic.

metrics.totalRU.UpdateIfHigher(consumption.RU)

Support for charging for cross-region network traffic was added by #105592.

Jira issue: CRDB-30444

@jeffswenson jeffswenson added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-multitenancy Related to multi-tenancy T-serverless labels Aug 8, 2023
@jeffswenson jeffswenson self-assigned this Aug 8, 2023
craig bot pushed a commit that referenced this issue Aug 24, 2023
109164: ui: show warning when data is not old enough r=maryliag a=maryliag

If a user selects a time period that we don't have the data for it (because it was already cleaned),
we show a warning to indicate the data might not be complete.

Fix #108989

<img width="334" alt="Screenshot 2023-08-23 at 5 30 18 PM" src="https://github.com/cockroachdb/cockroach/assets/1017486/ed9d9768-c4b4-456f-b5ce-0156bbfd9d4f">



https://www.loom.com/share/a7e0b0738d834bb0b6f38a9da43fb6a4


Release note (ui change): Show warning when time period selected on SQL Activity is older than the oldest data available.

109290: multitenantccl: add metric for network consumption r=JeffSwenson a=JeffSwenson

Previously, the cross region network portion of the RU consumption did not get its own line item in the TenantConsumption proto or the tenant consumption metrics. Now, the network component is removed from the kvRU field. Network cost is recorded in the TenantConsumption proto and exported as its own consumption metric.

The cross region network cost table was added by #105592 and is not yet deployed to production.

Release Note: None

Fixes: #108376

109351: changefeedccl: enable new webhook and pubsub sinks by default r=samiskin a=samiskin

Resolves #108806

This PR enables the new webhook and pubsub sink implementations by default. Leaving the settings in existence for near future in case something does go wrong, but I did not set them to public since there's no normal-operation reason to disable them.

Release note (performance improvement): changefeeds to webhook or pubsub endpoints now support much higher throughput

Co-authored-by: maryliag <[email protected]>
Co-authored-by: Jeff <[email protected]>
Co-authored-by: Shiranka Miskin <[email protected]>
@craig craig bot closed this as completed in 2171eca Aug 24, 2023
jeffswenson added a commit to jeffswenson/cockroach that referenced this issue Sep 5, 2023
Previously, the cross region network portion of the RU consumption did
not get its own line item in the TenantConsumption proto or the tenant
consumption metrics. Now, the network component is removed from the kvRU
field. Network cost is recorded in the TenantConsumption proto and
exported as its own consumption metric.

The cross region network cost table was added by cockroachdb#105592 and is not yet
deployed to production.

Release Note: None

Fixes: cockroachdb#108376
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-multitenancy Related to multi-tenancy C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-serverless
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant