changefeedccl: enable new webhook and pubsub sinks by default #109351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
jayshrivastava
approved these changes
Aug 23, 2023
Resolves cockroachdb#108806 This PR enables the new webhook and pubsub sink implementations by default. Leaving the settings in existence for near future in case something does go wrong, but I did not set them to public since there's no normal-operation reason to disable them. Release note (performance improvement): changefeeds to webhook or pubsub endpoints now support much higher throughput
samiskin
force-pushed
the
public-new-webhook-pubsub-sink
branch
from
6bc6701 to
2f47d86
Compare
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #108806
This PR enables the new webhook and pubsub sink implementations by default. Leaving the settings in existence for near future in case something does go wrong, but I did not set them to public since there's no normal-operation reason to disable them.
Release note (performance improvement): changefeeds to webhook or pubsub endpoints now support much higher throughput