Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multitenantccl: add metric for network consumption #109290

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

jeffswenson
Copy link
Collaborator

Previously, the cross region network portion of the RU consumption did not get its own line item in the TenantConsumption proto or the tenant consumption metrics. Now, the network component is removed from the kvRU field. Network cost is recorded in the TenantConsumption proto and exported as its own consumption metric.

The cross region network cost table was added by #105592 and is not yet deployed to production.

Release Note: None

Fixes: #108376

@jeffswenson jeffswenson requested review from a team as code owners August 22, 2023 21:35
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Previously, the cross region network portion of the RU consumption did
not get its own line item in the TenantConsumption proto or the tenant
consumption metrics. Now, the network component is removed from the kvRU
field. Network cost is recorded in the TenantConsumption proto and
exported as its own consumption metric.

The cross region network cost table was added by cockroachdb#105592 and is not yet
deployed to production.

Release Note: None

Fixes: cockroachdb#108376
@jeffswenson jeffswenson force-pushed the jeffswenson-network-metric branch from f6b78dd to 2171eca Compare August 23, 2023 13:43
@jeffswenson jeffswenson requested a review from a team August 24, 2023 13:33
Copy link
Contributor

@andy-kimball andy-kimball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@jeffswenson
Copy link
Collaborator Author

bors r+

@craig
Copy link
Contributor

craig bot commented Aug 24, 2023

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Metric For Cross Region Network RU Usage
3 participants