Added PyUnusedCodeBear to .coafile #582
Conversation
.coafile
Outdated
| @@ -27,6 +27,10 @@ bears = LineLengthBear | |||
| [all.links] | |||
| bears = InvalidLinkBear | |||
|
|
|||
| [all.unusedcode] | |||
There was a problem hiding this comment.
No need to make a separate section. You can include it under [all.python].
Also, read the commit guidelines and modify your commit according to it.
There was a problem hiding this comment.
Okay I will do the changes.
|
@nvzard Sorry, But I am not able to understand why the build is failing on semaphoreci. It would be great if you could help me. |
|
@Man-Jain sorry Internet was down whole day due to govt orders. Push again, most probably a restart will fix the semaphore build failure. Also, you need to rebase. |
|
@nvzard Surprisingly the internet was down in our city also due to Govt. Orders. I have done the other changes but in order to push from a a differnt branch I will have to create a new pull request. So should I close this Pull Request and open a new one? |
|
Don't close the PR. Your master is different from corobo's master, just fix that first and amend your changes. Keep it in mind and don't push from master next time. |
|
@nvzard The semaphoreci Docker is still failing. |
|
@meetmangukiya I can't figure out why @Man-Jain as mentioned in the commit guidelines, |
|
@nvzard I am very sorry for that mistake. I missed that part. I will surely take care of this next time. |
| for start, end in q_graph.edges(): | ||
| found_common = True |
There was a problem hiding this comment.
@Man-Jain don't make changes to answers/* and push your commit again. I am not sure, but this might work.
|
@Man-Jain Semaphore is failing because you pushed your commit from the master branch. Create a new branch and then push your commit. corobo/.ci/semaphore.answers.sh Line 8 in 861f7f8 |
|
@Man-Jain , dont create a new PR. I will try to fix this one for you. |
plugins/coatils.py
Outdated
| @@ -110,7 +109,7 @@ def ls(self, msg, match): | |||
| Example: `ls bears python python3` | |||
| """ | |||
| langs = list(map(lambda x: x.lower(), match.group(1).split())) | |||
| all_langs = Coatils.all_langs() | |||
| Coatils.all_langs() | |||
There was a problem hiding this comment.
the returned value wasnt being used, and invoking Coatils.all_langs doesnt have side-effects .
You can remove the line.
(whereas the self.pop_message() in coatils_test.py does have side effects and can not be removed.)
|
@nvzard Okay, I see I should have carefully made the pull request. |
|
@jayvdb Okay I will make the changes that you have suggested. |
|
please do it really quickly, as all other PRs need to wait for your one to be merged |
gitmate-bot
added
process/pending review
difficulty/newcomer
and removed
process/wip
labels
Added the PyUnusedCodeBear to the .coafile and ran coala command. This bear will remove the unused code from the project files. The bear is added to the [all.python] section. Fixes coala#531
|
ack 18a5b33 |
|
@gitmate-bot ff |
|
Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently |
|
Automated fastforward with GitMate.io was successful! 🎉 |
|
Yikes! We missed the 72 char commit body limit with this one 😥 |
.coafile : Added PyUnusedCodeBear to [all.python] section
Added the PyUnusedCodeBear to .coafile in [all.python] section and then ran coala command which removes the unused imports from project files.
Fixes :- #531