Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include PyUnusedCodeBear in .coafile to remove unused imports #531

Closed
nvzard opened this issue May 20, 2018 · 8 comments
Closed

Include PyUnusedCodeBear in .coafile to remove unused imports #531

nvzard opened this issue May 20, 2018 · 8 comments
Assignees
@Man-Jain
Labels
difficulty/newcomer

Comments

@nvzard
Copy link
Member

nvzard commented May 20, 2018

difficulty/newcomer
@jayvdb jayvdb mentioned this issue Jun 21, 2018
Closed
@Man-Jain
Copy link
Member

Man-Jain commented Jul 3, 2018

I would like to work on this issue can I be assigned this.

@Man-Jain
Copy link
Member

Man-Jain commented Jul 3, 2018

Can you please guide me so that I can begin with the issue.

@nvzard
Copy link
Member Author

nvzard commented Jul 3, 2018 •
edited
Loading

@Man-Jain are you familiar with using coala? If not take a look coala.io .

@Man-Jain
Copy link
Member

Sorry for the late reply @nvzard. Yes I am familier with the coala. I have used in one of my projects.

@nvzard
Copy link
Member Author

nvzard commented Jul 13, 2018

@Man-Jain then you just need to include PyUnusedCodeBear in this repo's .coafile , run coala and push the changes.

@nvzard nvzard closed this as completed Jul 13, 2018
@nvzard nvzard reopened this Jul 13, 2018
@nvzard
Copy link
Member Author

nvzard commented Jul 13, 2018

Sorry, closed by mistake.

@Man-Jain
Copy link
Member

@nvzard I have done all that you said. What should I do next.

@nvzard
Copy link
Member Author

nvzard commented Jul 13, 2018

Push your code and open a pull request.

@Man-Jain Man-Jain mentioned this issue Jul 14, 2018
Merged
Man-Jain added a commit to Man-Jain/corobo that referenced this issue Jul 16, 2018
@Man-Jain
.coafile: Added the PyUnusedCodeBear to the file
76cc206 
Added the PyUnusedCodeBear to the .coafile and ran coala command. This
bear will remove the unused code from the project files. The bear is
added to the [all.python] section.

Fixes coala#531
Man-Jain added a commit to Man-Jain/corobo that referenced this issue Jul 18, 2018
@Man-Jain
coatils.py: Remove Coatils.all_langs() from coatils.py
7a61478 
Removed the code from the file as invoking it doesn't have any side
effects.

Fixes :- coala#531
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Man-Jain Man-Jain

Labels
difficulty/newcomer
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Man-Jain @gitmate-bot @nvzard