Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

semaphore CI scripts assume master branch is main repo #583

Closed
jayvdb opened this issue Jul 18, 2018 · 1 comment · Fixed by Man-Jain/corobo#1
Closed

semaphore CI scripts assume master branch is main repo #583

jayvdb opened this issue Jul 18, 2018 · 1 comment · Fixed by Man-Jain/corobo#1
Assignees
@Man-Jain
Labels
difficulty/low importance/medium

Comments

@jayvdb
Copy link
Member

jayvdb commented Jul 18, 2018 

$ git grep master .ci/semaphore.*
.ci/semaphore.answers.sh:if [[ $BRANCH_NAME != "master" ]]
.ci/semaphore.docker.sh:if [[ $BRANCH_NAME == "master" ]]

Those assume that when BRANCH_NAME == "master", it is a push to the main repository.

It is quite common for people to accidentally build from the 'master' of forks, and submit PRs from that branch.

While it is highly undesirable that PRs come from master, and we intend to prevent it with a gitmate plugin, .ci/semaphore.docker.sh and .ci/semaphore.answers.sh should not break as a result. They should detect pull requests, and not do the deploy-preparation steps.

c.f. #582 (comment) which broke because of this, and probably other PRs also.
@starlord1311
Copy link

@jayvdb can i take up this issue?

Man-Jain added a commit to Man-Jain/corobo that referenced this issue Oct 14, 2018
@Man-Jain
ci: Add Pull request check to semaphore scripts
6d97fdf 
This fixes the conditions of build failure when someone created a
pull request from the master branch. It now also checks if it is a
Pull request or not.

Fixes coala#583
This was referenced Oct 14, 2018
Merged
Merged
Man-Jain added a commit to Man-Jain/corobo that referenced this issue Oct 14, 2018
@Man-Jain
ci: Add Pull request check to semaphore scripts
29d2031 
This fixes the conditions of build failure when someone created a
pull request from the master branch. It now also checks if it is a
Pull request or not.

Fixes coala#583
Man-Jain added a commit to Man-Jain/corobo that referenced this issue Oct 14, 2018
@Man-Jain
ci: Add Pull request check to semaphore scripts
b238aa4 
This fixes the conditions of build failure when someone created a
pull request from the master branch. It now also checks if it is a
Pull request or not.

Fixes coala#583
Man-Jain added a commit to Man-Jain/corobo that referenced this issue Oct 14, 2018
@Man-Jain
ci: Add Pull Request check to semaphore scripts
44e15d0 
This fixes the condition of build failure when someone creates a
pull request from the master branch. It now check that the project
is coala repo and then execute build steps

Fixes coala#583
Man-Jain added a commit to Man-Jain/corobo that referenced this issue Oct 14, 2018
@Man-Jain
ci: Add repository check to semaphore scripts
1823d47 
This fixes the condition of build failure when someone creates a
pull request from the master branch. It now check that the project
is coala/corobo repo and then execute build steps

Fixes coala#583
@Man-Jain Man-Jain mentioned this issue Oct 14, 2018
Merged
Man-Jain added a commit to Man-Jain/corobo that referenced this issue Oct 17, 2018
@Man-Jain
ci: Add repository check to semaphore scripts
4b41518 
This fixes the condition of build failure when someone creates a
pull request from the master branch. It now check that the project
is coala/corobo repo and then execute build steps

Fixes coala#583
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Man-Jain Man-Jain

Labels
difficulty/low importance/medium
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: Add Pull request check to semaphore scripts Man-Jain/corobo
3 participants
@jayvdb @Man-Jain @starlord1311