Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add Pull request check to semaphore scripts #2

Merged
merged 1 commit into from
Oct 14, 2018
Merged

Conversation

Man-Jain
Copy link
Owner

This fixes the conditions of build failure when someone created a
pull request from the master branch. It now also checks if it is a
Pull request or not.

Fixes coala#583

Reviewers Checklist

  • Appropriate logging is done.
  • Appropriate error responses.
  • Handle every possible exception.
  • Make sure there is a docstring in the command functions. Hint: Lookout for
    botcmd and re_botcmd decorators.
  • See that 100% coverage is there.
  • See to it that mocking is not done where it is not necessary.

This fixes the conditions of build failure when someone created a
pull request from the master branch. It now also checks if it is a
Pull request or not.

Fixes coala#583
@Man-Jain Man-Jain merged commit 29d2031 into manank-patch-1 Oct 14, 2018
@codecov-io
Copy link

codecov-io commented Oct 14, 2018

Codecov Report

Merging #2 into manank-patch-1 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##           manank-patch-1     #2   +/-   ##
=============================================
  Coverage             100%   100%           
=============================================
  Files                  17     17           
  Lines                 349    349           
  Branches               62     62           
=============================================
  Hits                  349    349

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aed83ca...29d2031. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants