Python minimum version 3.4.4 #2612
Conversation
|
Comment on 44012a9. Shortlog of the HEAD commit contains 52 character(s). This is 2 character(s) longer than the limit (52 > 50). Origin: GitCommitBear, Section: |
|
Demo of the py27 and py33 jobs: https://travis-ci.org/jayvdb/coala-bears/builds/404723796 |
|
Comment on 44012a9. Shortlog of the HEAD commit contains 52 character(s). This is 2 character(s) longer than the limit (52 > 50). Origin: GitCommitBear, Section: |
|
Demo https://travis-ci.org/jayvdb/coala-bears/builds/404768441 |
|
Comment on cc98e23. Shortlog of the HEAD commit contains 52 character(s). This is 2 character(s) longer than the limit (52 > 50). Origin: GitCommitBear, Section: |
Many of the bear dependencies are unable to be installed on older unsupported versions of Python. The unsupported tests objective is to verify that irrespective of any other failure to install, coala-bears has its own check to prevent running on older versions. Hence skipping the installation of bear dependencies ensures the check still works even if other packages dont break first. Closes coala#2488 Related to coala#2611
coala updated its minimum version to 3.4.4 a while ago and bears was not also updated. Adds tests to cover assert_supported_version, so that the pragma no cover can be removed and setup.py does not need to be run by coverage. Related to coala/coala#4350
Instead of setting coverage to run on all files
and omitting a list of files, replace
source = .
with
source = bears
This brings bears into line with setup.cfg.jj2
Related to https://gitlab.com/coala/mobans/issues/24
jayvdb
force-pushed
the
min-py344
branch
2 times, most recently
from
39273c1 to
d07dde4
Compare
This brings the bear script into line with the moban template. Also connect check_moban.sh with the moban asset. Related to https://gitlab.com/coala/mobans/issues/65
|
Fresh verification build https://travis-ci.org/jayvdb/coala-bears/builds/416374555 To verify yourself, cherry-pick the following and run on a fork diff --git a/.travis.yml b/.travis.yml
index c3e4fb4..80b0b6c 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -24,7 +24,7 @@ stages:
- test
- moban
- name: unsupported
- if: branch = master AND type = push
+ if: type != pull_request
.check_moban: &check_moban
<<: *disable_global |
|
LGTM. |
|
@gitmate-bot ff |
|
Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently |
|
Automated fastforward with GitMate.io was successful! 🎉 |
Closes #2611
Closes #2488