Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coala requires 3.4.4 but coala-bears requires 3.4.0 #2611

Closed
jayvdb opened this issue Jul 16, 2018 · 0 comments
Closed

coala requires 3.4.4 but coala-bears requires 3.4.0 #2611

jayvdb opened this issue Jul 16, 2018 · 0 comments
Assignees
Labels

Comments

@jayvdb
Copy link
Member

jayvdb commented Jul 16, 2018

coala/coala#4350 updated the minimum version of Python to 3.4.4, and coala-bears version checks were not updated at the same time.

We have two jobs which check the error message for other versions of Python, and even after 6906e54 they passed. They should have failed.

Those jobs were still installing the released package of coala, not the master.

The cause of that was https://gitlab.com/coala/mobans/issues/63

@jayvdb jayvdb self-assigned this Jul 16, 2018
jayvdb added a commit to jayvdb/coala-bears that referenced this issue Jul 16, 2018
Many of the bear dependencies are unable to be installed
on older unsupported versions of Python. The unsupported
tests objective is to verify that irrespective of any
other failure to install, coala-bears has its own check
to prevent running on older versions. Hence skipping the
installation of bear dependencies ensures the check
still works even if other packages dont break first.

Closes coala#2488
Related to coala#2611
jayvdb added a commit to jayvdb/coala-bears that referenced this issue Jul 17, 2018
Many of the bear dependencies are unable to be installed
on older unsupported versions of Python. The unsupported
tests objective is to verify that irrespective of any
other failure to install, coala-bears has its own check
to prevent running on older versions. Hence skipping the
installation of bear dependencies ensures the check
still works even if other packages dont break first.

Closes coala#2488
Related to coala#2611
jayvdb added a commit to jayvdb/coala-bears that referenced this issue Jul 17, 2018
jayvdb added a commit to jayvdb/coala that referenced this issue Jul 17, 2018
jayvdb added a commit to jayvdb/coala-bears that referenced this issue Jul 23, 2018
Many of the bear dependencies are unable to be installed
on older unsupported versions of Python. The unsupported
tests objective is to verify that irrespective of any
other failure to install, coala-bears has its own check
to prevent running on older versions. Hence skipping the
installation of bear dependencies ensures the check
still works even if other packages dont break first.

Closes coala#2488
Related to coala#2611
jayvdb added a commit to jayvdb/coala-bears that referenced this issue Aug 15, 2018
Many of the bear dependencies are unable to be installed
on older unsupported versions of Python. The unsupported
tests objective is to verify that irrespective of any
other failure to install, coala-bears has its own check
to prevent running on older versions. Hence skipping the
installation of bear dependencies ensures the check
still works even if other packages dont break first.

Closes coala#2488
Related to coala#2611
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

1 participant