Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RubyFastererBear.py: Add fasterer #2595

Merged
merged 1 commit into from
Jul 23, 2018
Merged

RubyFastererBear.py: Add fasterer #2595

merged 1 commit into from
Jul 23, 2018

Conversation

sangamcse
Copy link
Member

This adds a Local Bear for Ruby, wrapping
fasterer.

Closes #444

@sangamcse sangamcse force-pushed the fasterer branch 3 times, most recently from 58dc4f4 to 6738084 Compare July 8, 2018 16:53
jayvdb
jayvdb requested changes Jul 16, 2018
View reviewed changes
tests/ruby/fasterer_test_files/module_eval.rb Outdated
Hihi.hello

Hihi.module_eval %{
puts @foo
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two space indent please.

Also pls review #2561 so we can merge that and you can rebase on top of it. to avoid conflicting it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done @jayvdb

@jayvdb
Copy link
Member

jayvdb commented Jul 19, 2018

ack a4433ff

@jayvdb
Copy link
Member

jayvdb commented Jul 19, 2018

Waiting on #2612 and #2614 to be reviewed to avoid rebasing those ones.

@jayvdb
Copy link
Member

jayvdb commented Jul 23, 2018

@gitmate-bot rebase

@gitmate-bot
Copy link
Collaborator

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently ⚠️

@sangamcse @gitmate-bot
RubyFastererBear.py: Add fasterer
d63fee1 
This adds a `Local Bear` for `Ruby`, wrapping
`fasterer`.

Closes coala#444
@gitmate-bot
Copy link
Collaborator

Automated rebase with GitMate.io was successful! 🎉

@jayvdb
Copy link
Member

jayvdb commented Jul 23, 2018

@gitmate-bot ff

@gitmate-bot
Copy link
Collaborator

Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently ⚠️

@jayvdb
Copy link
Member

jayvdb commented Jul 23, 2018

@gitmate-bot ff

@gitmate-bot
Copy link
Collaborator

Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently ⚠️

@gitmate-bot
Copy link
Collaborator

Automated fastforward with GitMate.io was successful! 🎉

@gitmate-bot gitmate-bot merged commit d63fee1 into coala:master Jul 23, 2018
@sangamcse sangamcse deleted the fasterer branch July 24, 2018 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayvdb jayvdb jayvdb approved these changes

Assignees

@sangamcse sangamcse

Labels
area/lintbears process/approved size/S
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sangamcse @jayvdb @gitmate-bot