Temporary fixes for CheckstyleBear & RamllintBear #1471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adtac
reviewed
Mar 2, 2017
bears/java/CheckstyleBear.py
Outdated
| 'http://sourceforge.net/projects/checkstyle/files/checkstyle/6.15' | ||
| '/checkstyle-6.15-all.jar', | ||
| 'checkstyle.jar') | ||
| 'https://github.com/Berkeley-CS61B/skeleton-sp16/raw/master' |
There was a problem hiding this comment.
can we use our own fork of that? we don't know when that link would 404
There was a problem hiding this comment.
Or create a new repo and put all of our fetched files in it?
Fetching the jar from sourceforge.net is resulting in corrupt jar files, and the error reporting and recovery within coala isnt sufficient for this. Until the download code is more reliable, fetch the jar from GitHub. Related to coala#1461
adtac
reviewed
Mar 2, 2017
package.json
Outdated
| @@ -15,7 +15,7 @@ | |||
| "happiness": "~7.1.2", | |||
| "jshint": "~2", | |||
| "postcss-cli": "~2", | |||
| "ramllint": "~1.2.2", | |||
| "ramllint": ">1.2.2 <1.2.4", | |||
There was a problem hiding this comment.
Clarification: should this be >=1.2.2 or just >1.2.2?
There was a problem hiding this comment.
Oh, well spotted. Yes, 1.2.2 is still ok.
|
ack fd305e0 |
ramllint 1.2.4 is broken. Fixes coala#1470
|
ack 4daad8d |
|
@rultor merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workarounds for #1461 and #1470 .