Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrupted Jar files on Travis #1461

Open
jayvdb opened this issue Feb 27, 2017 · 2 comments
Open

Corrupted Jar files on Travis #1461

jayvdb opened this issue Feb 27, 2017 · 2 comments

Comments

@jayvdb
Copy link
Member

jayvdb commented Feb 27, 2017 •
edited
Loading

We've ended up with Jar files being downloaded from sf.net that java believes are corrupted.

$ file /home/travis/.local/share/coala-bears/CheckstyleBear/checkstyle.jar
/home/travis/.local/share/coala-bears/CheckstyleBear/checkstyle.jar: Java Jar file data (zip)
$ java -jar ~/.local/share/coala-bears/CheckstyleBear/checkstyle.jar -c /google_checks.xml tests/java/test_files/CheckstyleGood.java
Error: Invalid or corrupt jarfile /home/travis/.local/share/coala-bears/CheckstyleBear/checkstyle.jar

https://travis-ci.org/jayvdb/coala-bears/jobs/205642306#L2585

The jar from maven also has problems:

$ file /home/travis/.local/share/coala-bears/CheckstyleBear/checkstyle-6.15.jar
/home/travis/.local/share/coala-bears/CheckstyleBear/checkstyle-6.15.jar: Zip archive data, at least v1.0 to extract
$ java -jar ~/.local/share/coala-bears/CheckstyleBear/checkstyle-6.15.jar -c /google_checks.xml tests/java/test_files/CheckstyleGood.java
no main manifest attribute, in /home/travis/.local/share/coala-bears/CheckstyleBear/checkstyle-6.15.jar

https://travis-ci.org/jayvdb/coala-bears/jobs/205644853#L2586
@jayvdb
Copy link
Member Author

jayvdb commented Feb 27, 2017

green and red builds have the same version of Java installed.

@jayvdb
Copy link
Member Author

jayvdb commented Feb 27, 2017

Same thing happening on Appveyor:
https://ci.appveyor.com/project/jayvdb17618/coala-bears/build/job/qmn37w76ingaenro

@jayvdb jayvdb mentioned this issue Feb 28, 2017
Closed
@jayvdb jayvdb mentioned this issue Feb 28, 2017
Merged
2 tasks
@jayvdb jayvdb mentioned this issue Mar 1, 2017
Open
jayvdb added a commit to jayvdb/coala that referenced this issue Mar 1, 2017
@jayvdb
Bear: Raise exception on problematic HTTP status
422193a 
requests.Response.raise_for_status raises an exception
when the HTTP status code is 400-599.

Fixes coala#3803
Related to coala/coala-bears#1461
jayvdb added a commit to jayvdb/coala-bears that referenced this issue Mar 2, 2017
@jayvdb
CheckstyleBear: Fetch using alternative jar host
c99be88 
Fetching the jar from sourceforge.net is resulting in
corrupt jar files, and the error reporting and recovery
within coala isnt sufficient for this.

Until the download code is more reliable, fetch the jar
from https://josm.openstreetmap.de .

Related to coala#1461
jayvdb added a commit to jayvdb/coala-bears that referenced this issue Mar 2, 2017
@jayvdb
CheckstyleBear: Fetch jar from GitHub
066ae30 
Fetching the jar from sourceforge.net is resulting in
corrupt jar files, and the error reporting and recovery
within coala isnt sufficient for this.

Until the download code is more reliable, fetch the jar
from GitHub.

Related to coala#1461
@jayvdb jayvdb mentioned this issue Mar 2, 2017
Merged
@jayvdb jayvdb mentioned this issue Mar 2, 2017
Merged
jayvdb added a commit to jayvdb/coala-bears that referenced this issue Mar 2, 2017
@jayvdb
CheckstyleBear: Fetch jar from GitHub
fd305e0 
Fetching the jar from sourceforge.net is resulting in
corrupt jar files, and the error reporting and recovery
within coala isnt sufficient for this.

Until the download code is more reliable, fetch the jar
from GitHub.

Related to coala#1461
@jayvdb jayvdb mentioned this issue Mar 4, 2017
Closed
jayvdb added a commit to jayvdb/coala that referenced this issue Mar 4, 2017
@jayvdb
BearTest: Test exception during HTTP fetch
b99d2c3 
This test shows that a file is created and
still exists after a corrupted download.

Related to coala/coala-bears#1461
Closes coala#3820
gosom pushed a commit to gosom/coala-bears that referenced this issue Jul 15, 2017
@jayvdb
CheckstyleBear: Fetch jar from GitHub
1bbe39f 
Fetching the jar from sourceforge.net is resulting in
corrupt jar files, and the error reporting and recovery
within coala isnt sufficient for this.

Until the download code is more reliable, fetch the jar
from GitHub.

Related to coala#1461
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jayvdb @Makman2 @gitmate-bot