Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ramllint 1.2.4 and 1.3.0 broken #1470

Closed
jayvdb opened this issue Mar 2, 2017 · 3 comments · Fixed by #1565
Closed

ramllint 1.2.4 and 1.3.0 broken #1470

jayvdb opened this issue Mar 2, 2017 · 3 comments · Fixed by #1565
Assignees
@yash-nisar
Labels
importance/high upstream

Comments

@jayvdb
Copy link
Member

jayvdb commented Mar 2, 2017 •
edited
Loading

ramllint released 1.2.4 with a new feature, and then also 1.3.0 with the same new feature.

https://github.com/QuickenLoans/ramllint/pull/52

The 1.2.4 release breaks our test suite.

Our dependency is currently ramllint ~1.2.2 .
1.2.3 is a compatible change.
1.2.4 is not.
@jayvdb jayvdb changed the title ramllint 1.2.4 breaks the tests ramllint >1.2.3 broken Mar 2, 2017
@jayvdb
Copy link
Member Author

jayvdb commented Mar 2, 2017

The underlying issue is at https://github.com/QuickenLoans/ramllint/issues/53 . We need to blacklist 1.2.4 .

jayvdb added a commit to jayvdb/coala-bears that referenced this issue Mar 2, 2017
@jayvdb
RAMLLintBear: ramllint 1.2.4 is broken
ec23c25 
Fixes coala#1470
jayvdb added a commit to jayvdb/coala-bears that referenced this issue Mar 2, 2017
@jayvdb
RAMLLintBear: ramllint 1.2.4 is broken
d92b75c 
Fixes coala#1470
jayvdb added a commit to jayvdb/coala-bears that referenced this issue Mar 2, 2017
@jayvdb
RAMLLintBear: ramllint 1.2.4 is broken
e1db85a 
Fixes coala#1470
jayvdb added a commit to jayvdb/coala-bears that referenced this issue Mar 2, 2017
@jayvdb
RAMLLintBear: Reject ramllint 1.2.4
0f089ec 
ramllint 1.2.4 is broken.

Fixes coala#1470
@jayvdb jayvdb mentioned this issue Mar 2, 2017
Merged
jayvdb added a commit to jayvdb/coala-bears that referenced this issue Mar 2, 2017
@jayvdb
RAMLLintBear: Reject ramllint 1.2.4
34e24a6 
ramllint 1.2.4 is broken.

Fixes coala#1470
@jayvdb
Copy link
Member Author

jayvdb commented Mar 2, 2017

A dedicated upstream request for 1.2.4 to be somehow removed. https://github.com/QuickenLoans/ramllint/issues/56

jayvdb added a commit to jayvdb/coala-bears that referenced this issue Mar 2, 2017
@jayvdb
RAMLLintBear: Reject ramllint 1.2.4
a549fba 
ramllint 1.2.4 is broken.

Fixes coala#1470
@rultor rultor closed this as completed in 4daad8d Mar 2, 2017
@jayvdb jayvdb mentioned this issue Mar 4, 2017
Closed
@jayvdb jayvdb changed the title ramllint >1.2.3 broken ramllint 1.2.4 and 1.3.0 broken Mar 5, 2017
@jayvdb
Copy link
Member Author

jayvdb commented Mar 5, 2017 •
edited
Loading

Note this has been effectively fixed upstream. '1.2.4' has been marked deprecated, and 1.2.5 & 1.2.6 should now be compatible with 1.2.2 . (needs checking..)

Our dependency should now be updated to something like "~1.2.2 !=1.2.4" (maybe not exact syntax).

@jayvdb jayvdb reopened this Mar 5, 2017
yash-nisar added a commit to yash-nisar/coala-bears that referenced this issue Mar 29, 2017
@yash-nisar
RAMLLintBear.py: Update NpmRequirement version
beee3dd 
Update NpmRequirement version to include a range of
versions >=1.2.2 <1.2.4 || >=1.2.5 <1.3.0 since
version 1.2.4 has been marked depreciated.

Fixes coala#1470
@yash-nisar yash-nisar mentioned this issue Mar 29, 2017
Merged
2 tasks
gosom pushed a commit to gosom/coala-bears that referenced this issue Jul 15, 2017
@jayvdb
RAMLLintBear: Reject ramllint 1.2.4
8d3c77e 
ramllint 1.2.4 is broken.

Fixes coala#1470
gosom pushed a commit to gosom/coala-bears that referenced this issue Jul 15, 2017
@yash-nisar
RAMLLintBear.py: Update NpmRequirement version
1b076e1 
Update NpmRequirement version to include a range of
versions >=1.2.2 <1.2.4 || >=1.2.5 <1.3.0 since
version 1.2.4 has been marked depreciated.

Fixes coala#1470
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yash-nisar yash-nisar

Labels
importance/high upstream
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

RAMLLintBear.py: Update NpmRequirement version yash-nisar/coala-bears
2 participants
@jayvdb @yash-nisar