Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RAMLLintBear.py: Update NpmRequirement version #1565

Merged
merged 1 commit into from
Mar 29, 2017

Conversation

yash-nisar
Copy link
Member

@yash-nisar yash-nisar commented Mar 29, 2017

Update NpmRequirement version to include a range of
versions >=1.2.2 <1.2.4 || >=1.2.5 <1.3.0 since
version 1.2.4 has been marked depreciated.

Fixes #1470

For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!

Checklist

  • I read the commit guidelines and I've followed
    them.
  • I ran coala over my code locally. (All commits have to pass
    individually.
    It is not sufficient to have "fixup commits" on your PR,
    our bot will still report the issues for the previous commit.) You will
    likely receive a lot of bot comments and build failures if coala does not
    pass on every single commit!

After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.

Please consider helping us by reviewing other peoples pull requests as well:

The more you review, the more your score will grow at coala.io and we will
review your PRs faster!

Update NpmRequirement version to include a range of
versions >=1.2.2 <1.2.4 || >=1.2.5 <1.3.0 since
version 1.2.4 has been marked depreciated.

Fixes coala#1470
@jayvdb
Copy link
Member

jayvdb commented Mar 29, 2017

ack beee3dd

@jayvdb
Copy link
Member

jayvdb commented Mar 29, 2017

@rultor merge

@rultor
Copy link

rultor commented Mar 29, 2017

@rultor merge

@jayvdb OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit beee3dd into coala:master Mar 29, 2017
@rultor
Copy link

rultor commented Mar 29, 2017

@rultor merge

@jayvdb Done! FYI, the full log is here (took me 1min)

@yash-nisar yash-nisar deleted the iss#1470 branch March 29, 2017 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

ramllint 1.2.4 and 1.3.0 broken
4 participants