Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature/771] Github Actions: Env vars to configure docker images + new Alpine dockerfile for Crystal v1 #889

Merged
merged 5 commits into from
Aug 2, 2021

Conversation

HashNuke
Copy link
Collaborator

@HashNuke HashNuke commented Jul 28, 2021

Description

  • Moves out image names to env vars in the Github Actions file
  • Adds new Dockerfile for building the image for the Crystal v1 (this was AFAIK missing in the repo - so we don't have the source for the image being used for Crystal 0.35 in main branch)

If the PR looks good, apart from merging it, we should complete the following tasks to allow the next PR for Crystal v1 upgrade.

[Task] Push a new image for conformance/crystal

  • Push conformance/crystal image to DockerHub
export IMAGE_NAME="conformance/crystal:1.0.0-alpine-r1" && \
docker build -t $IMAGE_NAME tools -f tools/crystal-alpine.dockerfile && \
docker push $IMAGE_NAME

[Task] Push new image for conformance/offline

  • Push conformance/offline image to DockerHub
export IMAGE_NAME="conformance/offline:crystal-1.0.0-r1"

# Build the conformance/node image
docker build -t conformance/node:v1.21.1 tools/airgapped_kind/kind_node
docker save conformance/node:v1.21.1 > tools/airgapped_kind/kind_node/node.tar.gz

# Build the conformance/offline image (uses the tar file of the conformance/node image)
docker build -t $IMAGE_NAME tools/airgapped_kind
docker push $IMAGE_NAME

Issues:

Refs: #771

How has this been tested:

  • Covered by existing integration testing
  • Added integration testing to cover
  • Verified all A/C passes
    • develop
    • master
    • tag/other branch
  • Test environment
    • Shared Packet K8s cluster
    • New Packet K8s cluster
    • Kind cluster
  • Have not tested

Types of changes:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

Documentation

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • No updates required.

Code Review

  • Does the test handle fatal exceptions, ie. rescue block

Issue

  • Tasks in issue are checked off

@HashNuke
Copy link
Collaborator Author

For the docker images, the PR currently names the tags by crystal versions and allowing for new versions with r{n}. I just picked this naming convention - no strong preference. I'm open to any other naming convention.

@HashNuke HashNuke closed this Jul 28, 2021
@HashNuke HashNuke reopened this Jul 28, 2021
@HashNuke HashNuke marked this pull request as draft July 28, 2021 15:41
@HashNuke HashNuke mentioned this pull request Jul 28, 2021
30 tasks
@HashNuke HashNuke changed the title Add env vars to Github Actions to configure docker images to use + new Alpine dockerfile for Crystal v1 [feature/771] Github Actions: Env vars to configure docker images + new Alpine dockerfile for Crystal v1 Jul 28, 2021
@HashNuke HashNuke linked an issue Jul 29, 2021 that may be closed by this pull request
8 tasks
@HashNuke HashNuke marked this pull request as ready for review August 2, 2021 18:45
@agentpoyo agentpoyo self-requested a review August 2, 2021 19:54
Copy link
Collaborator

@agentpoyo agentpoyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agentpoyo agentpoyo merged commit bd577bb into main Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Maintenance] Update version of Crystal lang to GA Release, v1.0.0
2 participants