[Maintenance] Update version of Crystal lang to GA Release, v1.0.0

[lixuna]

Describe the maintenance item

• the CNF Test Suite currently supports Crystal Language version Crystal 0.35.1 "and the locked in shards versions"
• Crystal's GA 1.0 release has been available since March 22, 2021
• Update the CNF Test Suite to support Crystal's 1.0 release, see https://github.com/crystal-lang/crystal/releases/tag/1.0.0

Expected behavior

• the CNF Test Suite will function as expected after updating Crystal from 0.35.1 to 1.0

How will this be tested? aka Acceptance Criteria (optional)

• All documentation is updated to mention the updated Crystal version, 1.0.0
• Install works as expected
• Running all tests works as expected
• Running workload-only works as expected
• Running platform-only works as expected
• Running individual test categories works as expected
• Running individual tests works as expected
• tbd, add more expectations as needed

Additional context

• the current version of Crystal on CNF Test Suite (v0.35.1) is 3 versions behind the 1.0.0 release

[HashNuke]

Below are my activities so far

• I reviewed the changelogs of the dependencies and made appropriate updates to the shard.yml of the project.
• Commented out the crystal-community/icr dependency for now. Will add it back if required/possible after the v1.0 upgrade.

Local build compiled fine. Yet to fix GitHub actions.

Notes on changelogs

• icyleaf/totem
  • Changelog
  • No code changes
  • Only upgrade to 0.7.0
• icyleaf/halite
  • Changelog
  • No code changes
  • Only upgrade to 0.12.0
• mrrooijen/commander
  • Changelog
  • No upgrade required
  • No code changes
• vulk/sam.cr
  • No changelog
  • Have to make this compatible with Crystal v1.0.0
  • Temporarily forked it as HashNuke/sam.cr and updated shard.yml to allow Crystal 1.0.0 (working branch)
• straight-shoota/crinja
  • Changelog
  • No code changes
• Sija/retriable.cr
  • No code changes required
  • Sent PR to the repo to allow Crystal v1.0.0. Temporarily building from HashNuke/retriable.cr
• crystal-ameba/ameba
  • No changelog available
  • Be brave and upgrade to 0.14.3. Let us see what breaks.
• Crystal changelog
  • Changelog
  • Make changes based on build output

Here's where I am blocked

Made an attempt (branch: crystal-v1). Noticed that we are using two docker images in the github actions

• conformance/crystal
• conformance/offline

I could not find the source docker files for these images to attempt an upgrade. Blocked with this.

[HashNuke]

Update: 30 June 2021

• GitHub Actions build now uses a custom image for crystal now for the github actions.
• Added this new dockerfile to the repo incase we want to update the Crystal version again sometime later.
• Temporarily pushed this docker image to my own namespace hashnuke/crystal-custom:1.0.0-alpine-r1.
• All tests except the 3 airgapped tests are passing according to the latest build as of this comment.
• Team confirmed that there might be an issue with the self-hosted github action runners.

Will try running the tests tomorrow after the self-hosted runners are fixed.

[HashNuke]

Update: 01 July 2021

• The build is green now after the team fixed the self-hosted runners.
• Next: Will check if icr can be added back.

[HashNuke]

Update: 05 July 2021

Build is green. But I'm maintaining the following forks temporarily:

• Fork of crystal-readline
  • crystal-v1 branch. Required by icr
  • PR to main repo
• Fork of icr
  • crystal-v1 branch
  • Can send a PR to icr main repo only if PR to crystal-readline this is merged.
• Fork of sam.cr - v1-upgrade branch

[HashNuke]

We cannot merge this until icr shard supports Crystal 1.0, which in turn depends on crystal-readline.

• We'll have to wait until this PR is merged
• Added the blocked label to this task.

[williscool]

@HashNuke looks like you should be able to merge this now

crystal-lang/crystal-readline#5

[HashNuke]

Update: Sent PR-131 to icr to update Crystal version.

[agentpoyo]

Acceptance Criteria:

Crystal Version 1.0.0 Support:

• Setup and configure crystal v1.0.0 on workstation or instance that cnf-testsuite will be installed onto. See https://crystal-lang.org/install/ for more details for OS version used.
• Verify crystal version is 1.0.0 with crystal version command.
• Download source from git repo for cnf-testsuite: git clone [email protected]:cncf/cnf-testsuite.git
• cd cnf-testsuite and then run shards install to verify shards dependencies are downloaded without error: shards install
• Now run crystal build src/cnf-testsuite.cr --warnings none if shards install had no errors to build the cnf-testsuite binary.
• Once built, you can verify the binary by running ./cnf-testsuite version and it should tell you the current main branch version, ex. CNF TestSuite version: main-2021-08-04-230419-fba71fc
• Now you can run cnf_setup and workload tests.
• After successful cnf_setup, I can see screenshots of a successful workload or other test performed on cnf-testsuite using crystal v1.0.0

[agentpoyo]

[agentpoyo]

[lixuna]

@agentpoyo @denverwilliams @wavell @HashNuke what is the level of effort in points for this issue? (ex. 0,1,2,3,5,8,13,21)

[agentpoyo]

8pts