Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature/771] Crystal v1 update #890

Merged
merged 4 commits into from
Aug 3, 2021
Merged

[feature/771] Crystal v1 update #890

merged 4 commits into from
Aug 3, 2021

Conversation

HashNuke
Copy link
Collaborator

@HashNuke HashNuke commented Jul 28, 2021

Description

  • Migrates project to Crystal 1.0.0
  • Uses new docker images for Crystal 1.0.0 (temporarily forks of conformance/offline and conformance/crystal)
  • Updates dependencies in shards.yml

Checklist for Crystal update

Prerequisites

  • Push new docker images as per action-items in the PR description on #889
    • conformance/crystal:1.0.0-alpine-r1 image is available
    • conformance/offline:crystal-1.0.0-r1 image is available
  • Merge #889 into main branch
  • Merge vulk/sam.cr#2

Tasks to update this PR after prerequisites are ready

  • Update sam.cr to point to vulk folk in shard.yml
  • Update actions.yml to use new docker images from #889 action-items
  • Update tools/airgapped_kind/Dockerfile pointing to new docker image for conformance/crystal
  • Test crystal-v1-update branch with new docker images
  • Change PR status from Draft to ReadyToMerge

Issues:

Refs: #771

How has this been tested:

  • Covered by existing integration testing
  • Added integration testing to cover
  • Verified all A/C passes
    • develop
    • master
    • tag/other branch
  • Test environment
    • Shared Packet K8s cluster
    • New Packet K8s cluster
    • Kind cluster
  • Have not tested

Types of changes:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

Documentation

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • No updates required.

Code Review

  • Does the test handle fatal exceptions, ie. rescue block

Issue

  • Tasks in issue are checked off

* Replace logger with log for crystal 1.0
* Update shard.lock with new version of retriable.cr
* Add Crystal v1.0.0-alpine dockerfile
* Update icr to latest master
* Change crystal version for github-runner image
* Add tools/airgapped_kind/kind_node/node.tar.gz to gitignore
* Additionally: Merged some changes from PR-889 to help with getting a green build

Temporary changes (until PR is merged):
* Update dockerfile for conformance/offline to use custom Crystal 1.0 image
* Update actions.yml to use fork of the following docker images
  * hashnuke/conformance-offline instead of conformance/offline
  * hashnuke/crystal instead of conformance/crystal
@HashNuke HashNuke changed the title Crystal v1 update [feature/771] Crystal v1 update Jul 28, 2021
@HashNuke HashNuke requested review from denverwilliams and wvwatson and removed request for denverwilliams July 28, 2021 18:01
@HashNuke HashNuke linked an issue Jul 29, 2021 that may be closed by this pull request
8 tasks
@HashNuke HashNuke marked this pull request as ready for review August 3, 2021 14:21
@wvwatson wvwatson merged commit 8d8826b into main Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Maintenance] Update version of Crystal lang to GA Release, v1.0.0
2 participants