create kind network

[nabuskey]

The test assume we have a docker network named "kind". Since the test only cares about registry image, we'll just create the network prior to reconciling.

Note that we will not need this functionality going forward. If we did, I think the way @cmoulliard did with test containers is the way to go. I want to fix tests so we don't run into test failures for unrelated PRs.

ubuntu@ip-10-192-11-119:~/idpbuilder$ go test github.com/cnoe-io/idpbuilder/pkg/kind -run '^\QTestReconcileRegistry\E$'
ok  	github.com/cnoe-io/idpbuilder/pkg/kind	4.495s
ubuntu@ip-10-192-11-119:~/idpbuilder$ docker images
REPOSITORY   TAG       IMAGE ID   CREATED   SIZE
ubuntu@ip-10-192-11-119:~/idpbuilder$ docker network ls
NETWORK ID     NAME      DRIVER    SCOPE
906d8469762b   bridge    bridge    local
90ea394ecb86   host      host      local
44350ca9e837   none      null      local

fixes: #28

[nabuskey]

Well, it passes the tests now. I will say that this is very fragile and I can't reproduce the previous test failures on my Linux system.

Good news is that we don't need these tests going forward.

[nimakaviani]

LGTM

yay, first green build. thanks!

[nimakaviani]

cosmetics here but pushing the check to a go func would be nicer

Suggested change

	for {
	if time.Now().After(endTime) {
	t.Fatalf("Timed out waiting for port %d to be available", kind.ExposedRegistryPort)
	}
	conn, cErr := net.DialTimeout("tcp", net.JoinHostPort("0.0.0.0", strconv.Itoa(int(kind.ExposedRegistryPort))), time.Second*3)
	if cErr != nil {
	break
	}
	conn.Close()
	time.Sleep(waitInterval)
	ready := make(chan bool)
	endTime := time.After(waitTimeout)
	go func() {
	for {
	....
	if cErr == nil {
	close(ready)
	}
	}
	}()
	select {
	case <-timeout:
	err := errors.New("Timeout")
	log.Error(err, "Didn't reconcile Gitea on time.")
	return ctrl.Result{}, err
	case <-ready:
	log.Info("Gitea is ready!")
	resource.Status.GiteaAvailable = true
	}

[nabuskey]

I'm using the same format that was used here:

idpbuilder/pkg/controllers/gitserver/controller_test.go

Line 120 in f6a3d8b

endTime := time.Now().Add(timeout)

If we are using timeout, we should use the same logic everywhere or make it reusable. not worth the time effort imo.

[nimakaviani]

yeah not a big deal, lets get it over the line.

[nimakaviani]

same as above