Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests #28

Closed
nabuskey opened this issue Oct 16, 2023 · 5 comments · Fixed by #67
Closed

Fix tests #28

nabuskey opened this issue Oct 16, 2023 · 5 comments · Fixed by #67
Assignees
Labels
bug Something isn't working

Comments

@nabuskey
Copy link
Collaborator

nabuskey commented Oct 16, 2023

Currently tests are broken. Need to fix them.

An example failed run
https://github.com/cnoe-io/idpbuilder/actions/runs/6532866095/job/17750266601

#36

@nabuskey nabuskey added the bug Something isn't working label Oct 16, 2023
@cmoulliard
Copy link
Contributor

The problem is related to this error registry_test.go:31: Error reconciling registry: Error response from daemon: network kind not found

@cmoulliard
Copy link
Contributor

Controller_test fails as content compared diverges from the existing kind config

/opt/homebrew/opt/go/libexec/bin/go tool test2json -t /Users/cmoullia/Library/Caches/JetBrains/IntelliJIdea2023.2/tmp/GoLand/___cluster_test_go.test -test.v -test.paniconexit0 -test.run ^\QTestGetConfig\E$
=== RUN   TestGetConfig
    cluster_test.go:55: Got config: # two node (one workers) cluster config
        # Kind kubernetes release images https://github.com/kubernetes-sigs/kind/releases
        kind: Cluster
        apiVersion: kind.x-k8s.io/v1alpha4
        containerdConfigPatches:
        - |-
          [plugins."io.containerd.grpc.v1.cri".registry.mirrors."localhost:5001"]
            endpoint = ["http://idpbuilder-testcase-registry:5000"]
        nodes:
        - role: control-plane
          image: "kindest/node:v1.26.3"
          kubeadmConfigPatches:
          - |
            kind: InitConfiguration
            nodeRegistration:
              kubeletExtraArgs:
                system-reserved: memory=4Gi
                node-labels: "ingress-ready=true"
          extraPortMappings:
          - containerPort: 80
            hostPort: 8880
            protocol: TCP
          - containerPort: 443
            hostPort: 8443
            protocol: TCP
          -
        - role: worker
          image: "kindest/node:v1.26.3"
          kubeadmConfigPatches:
          - |
            kind: JoinConfiguration
            nodeRegistration:
              kubeletExtraArgs:
                system-reserved: memory=4Gi

@cmoulliard
Copy link
Contributor

cmoulliard commented Oct 18, 2023

Do you plan to create a PR to fix the issues with the test ? @nabuskey
I created a commit that you could already include. See: cc922d4

@nabuskey
Copy link
Collaborator Author

Yes, I am documenting issues with tests. I think there are multiple issues with the tests see:

#36
#37

As for your fix, I would love to see a PR :) @cmoulliard

@nabuskey nabuskey self-assigned this Oct 18, 2023
@cmoulliard
Copy link
Contributor

I will create a draft PR to at least fix the 2 issues I discovered (argo_test.go, cluster_test.go)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants