Image digest is used for image ID

[nabuskey]

The image ID field is filled with image digest, not image ID.

idpbuilder/pkg/controllers/gitserver/image.go

Lines 53 to 62 in 1a9acbb

	regImgId, err := apps.PushImage(ctx, dockerClient, imageTag)
	if err != nil {
	return ctrl.Result{}, err
	}
	if regImgId == nil {
	return ctrl.Result{}, fmt.Errorf("failed to get registry image id after push")
	}
	resource.Status.ImageID = *regImgId

PushImage returns:

idpbuilder/pkg/apps/image.go

Lines 55 to 63 in 1a9acbb

	di, err := client.DistributionInspect(ctx, tag, authConfig)
	if err != nil {
	return nil, err
	}
	regImgId := di.Descriptor.Digest.String()
	log.Info("Image Pushed", "digest", regImgId)
	return &regImgId, nil

Because digest is passed to Docker client, the test fails.

idpbuilder/pkg/controllers/gitserver/image_test.go

Line 55 in 1a9acbb

_, err = dockerClient.ImageRemove(ctx, resource.Status.ImageID, types.ImageRemoveOptions{})

Did we meant to return the digest instead of id in this?

idpbuilder/pkg/apps/image.go

Line 23 in 1a9acbb

func PushImage(ctx context.Context, client *dockerClient.Client, tag string) (*string, error) {

[nimakaviani]

I think we should populate GitServerStatus to keep both the imageId and the imageDigest. the data will come in handy later on

[nimakaviani]

well actually thinking about it more and looking at the code, the image ID is rather fixed, knowing the GitResource. for the test to pass, we just need to make sure the reference contains both the id and its SHA256. I will send a fix for this.