Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start registry container #69

Closed
wants to merge 1 commit into from
Closed

Conversation

nabuskey
Copy link
Collaborator

Fixes the issue with the test on git image where you get a error message like this

--- FAIL: TestReconcileGitServerImage (19.02s)
    image_test.go:44: reconcile error: Error response from daemon: Get "http://localhost:5001/v2/": dial tcp [::1]:5001: connect: connection refused
    image_test.go:48: Invalid or no Image ID in status: ""
    image_test.go:59: Removing docker image: Error response from daemon: invalid reference format
FAIL

It starts a registry container so it can get the digest. Definitely not the best way to go about testing these but we shouldn't need the code tested going forward.

Signed-off-by: Manabu Mccloskey <[email protected]>
@nabuskey nabuskey marked this pull request as draft October 26, 2023 20:39
@nimakaviani nimakaviani self-requested a review October 26, 2023 22:36
Copy link
Contributor

@nimakaviani nimakaviani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

I saw this failure when I was testing the fix for creating the kind network. lets get it over the line and get to green before cutting the first release

@nimakaviani nimakaviani added this to the v0.1 release milestone Oct 26, 2023
@nabuskey
Copy link
Collaborator Author

Closing this because build issues are closely related to #67

Will handle both in that PR

@nabuskey nabuskey closed this Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants