-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
simplify flat mixing configuration #46948
Conversation
cms-bot internal usage |
assign simulation |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46948/43016 |
New categories assigned: simulation @civanch,@kpedro88,@mdhildreth you have been requested to review this Pull request/Issue and eventually sign? Thanks |
A new Pull Request was created by @vlimant for master. It involves the following packages:
@antoniovilela, @civanch, @cmsbuild, @davidlange6, @fabiocos, @kpedro88, @mandrenguyen, @mdhildreth, @rappoccio can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Size: This PR adds an extra 12KB to repository
Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @mandrenguyen, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
When defining a flat mixing that is not in the release, one has to use the --customise_command .
With this PR it becomes simpler, just by adding
--pileup 'Flat_10_50_25ns,{"Flat":[0,120]}'
instead ofPR validation:
the cmsDriver with the short option returns a valid configuration file.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
this might need to get back ported if people find this useful