Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DQM] Replace fabs with std::abs to fix clang warnings #46971

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

iarspider
Copy link
Contributor

@iarspider iarspider commented Dec 17, 2024

PR description:

Title says it all. Compilation logs: 1, 2, 3.

PR validation:

Bot tests

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 17, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @iarspider for master.

It involves the following packages:

  • DPGAnalysis/HcalTools (dqm)

@antoniovagnerini, @cmsbuild, @rseidita can you please review it and eventually sign? Thanks.
@mmusich this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Pull request #46971 was updated. @antoniovagnerini, @cmsbuild, @rseidita can you please check and sign again.

@iarspider
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 96KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3265dc/43489/summary.html
COMMIT: 3bc5fd9
CMSSW: CMSSW_15_0_X_2024-12-16-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46971/43489/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3265dc/43489/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3265dc/43489/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3510017
  • DQMHistoTests: Total failures: 407
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3509590
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
  • Checked 202 log files, 172 edm output root files, 46 DQM output files
  • TriggerResults: no differences found

@iarspider
Copy link
Contributor Author

please test for CMSSW_15_0_CLANG_X

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3265dc/43498/summary.html
COMMIT: 3bc5fd9
CMSSW: CMSSW_15_0_CLANG_X_2024-12-16-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46971/43498/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3265dc/43498/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3265dc/43498/git-merge-result

Comparison Summary

Summary:

  • You potentially removed 46 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 90456 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3510017
  • DQMHistoTests: Total failures: 383664
  • DQMHistoTests: Total nulls: 273
  • DQMHistoTests: Total successes: 3126060
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 2.806 KiB( 45 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): -0.127 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 13034.0 ): 2.649 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 2022.002001 ): -0.012 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 2023.002001 ): -0.008 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 250202.181 ): -0.229 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): 0.189 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 7.3 ): 0.344 KiB SiStrip/MechanicalView
  • Checked 202 log files, 172 edm output root files, 46 DQM output files
  • TriggerResults: found differences in 18 / 44 workflows

@antoniovagnerini
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @mandrenguyen, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit c10b07d into cms-sw:master Dec 19, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants