[Geometry] Use std::abs to fix clang compilation warnings

[iarspider]

PR description:

Title says it all. Compilation log: link

PR validation:

Bot tests

[iarspider]

please test

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46973/43048

[cmsbuild]

A new Pull Request was created by @iarspider for master.

It involves the following packages:

• DetectorDescription/DDCMS (geometry)

@Dr15Jones, @bsunanda, @civanch, @kpedro88, @makortel, @mdhildreth can you please review it and eventually sign? Thanks.
@fabiocos, @martinamalberti, @slomeo, @vargasa this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

-1

Failed Tests: RelVals RelVals-INPUT
Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b74219/43491/summary.html
COMMIT: 66e2850
CMSSW: CMSSW_15_0_X_2024-12-16-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46973/43491/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @vlimant simplify flat mixing configuration #46948

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b74219/43491/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b74219/43491/git-merge-result

RelVals

• 2024.101001DAS Error
• 2024.202001DAS Error

RelVals-INPUT

• 2024.303001DAS Error
• 2024.300001DAS Error
• 2024.203001DAS Error

Expand to see more relval errors ...

• 2024.103001
• 2024.302001
• 2024.101001
• 2024.102001
• 2024.200001
• 2024.202001
• 2024.201001
• 2024.301001

[iarspider]

@cmsbuild please ignore tests-rejected with ib-failure

[iarspider]

please test for CMSSW_15_0_CLANG_X

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b74219/43497/summary.html
COMMIT: 66e2850
CMSSW: CMSSW_15_0_CLANG_X_2024-12-16-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46973/43497/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @vlimant simplify flat mixing configuration #46948

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b74219/43497/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b74219/43497/git-merge-result

Comparison Summary

Summary:

• You potentially removed 46 lines from the logs
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 90456 differences found in the comparisons
• DQMHistoTests: Total files compared: 46
• DQMHistoTests: Total histograms compared: 3510017
• DQMHistoTests: Total failures: 383664
• DQMHistoTests: Total nulls: 273
• DQMHistoTests: Total successes: 3126060
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 2.806 KiB( 45 files compared)
• DQMHistoSizes: changed ( 10224.0 ): -0.127 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 13034.0 ): 2.649 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 2022.002001 ): -0.012 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 2023.002001 ): -0.008 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 250202.181 ): -0.229 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 25202.0 ): 0.189 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 7.3 ): 0.344 KiB SiStrip/MechanicalView
• Checked 202 log files, 172 edm output root files, 46 DQM output files
• TriggerResults: found differences in 18 / 44 workflows

[civanch]

please test

[cmsbuild]

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b74219/43595/summary.html
COMMIT: 66e2850
CMSSW: CMSSW_15_0_X_2024-12-20-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46973/43595/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 2 lines from the logs
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3818730
• DQMHistoTests: Total failures: 415
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3818295
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 214 log files, 184 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @mandrenguyen, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1