-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Class version update unit test fix #46870
Conversation
cms-bot internal usage |
please test for CMSSW_15_0_X |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46870/42898 |
A new Pull Request was created by @smuzaffar for master. It involves the following packages:
@Dr15Jones, @makortel, @smuzaffar can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test for CMSSW_15_0_DEVEL_X |
unit tests passed now for DEVEL IB PR tests |
Thanks @smuzaffar! |
+1 Size: This PR adds an extra 16KB to repository Comparison SummaryThere are some workflows for which there are errors in the baseline: Summary:
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-42b874/43252/summary.html Comparison SummaryThere are some workflows for which there are errors in the baseline: Summary:
|
+core |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @mandrenguyen, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
urgent |
type bugfix |
@cms-sw/orp-l2 , can you please review this? |
+1 |
This should fix the failing
TestFWCoreReflectionClassVersionUpdate
unit test.There was a bug and
scram build
was not running the edm class version that is why scram build (run via this test) was not failing. The bug has been fixed soscram build
now correctly fails which causes this unit test to not work.This change allows scram to build the test library without running edm class checks during the
scram build
phase.Fixes #46869