Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class version update unit test fix #46870

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

smuzaffar
Copy link
Contributor

@smuzaffar smuzaffar commented Dec 4, 2024

This should fix the failing TestFWCoreReflectionClassVersionUpdate unit test.

There was a bug and scram build was not running the edm class version that is why scram build (run via this test) was not failing. The bug has been fixed so scram build now correctly fails which causes this unit test to not work.

This change allows scram to build the test library without running edm class checks during the scram build phase.

Fixes #46869

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2024

cms-bot internal usage

@smuzaffar
Copy link
Contributor Author

please test for CMSSW_15_0_X

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2024

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2024

A new Pull Request was created by @smuzaffar for master.

It involves the following packages:

  • FWCore/Reflection (core)

@Dr15Jones, @makortel, @smuzaffar can you please review it and eventually sign? Thanks.
@makortel, @missirol, @wddgit this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@smuzaffar
Copy link
Contributor Author

please test for CMSSW_15_0_DEVEL_X

@smuzaffar
Copy link
Contributor Author

unit tests passed now for DEVEL IB PR tests

@makortel
Copy link
Contributor

makortel commented Dec 4, 2024

Thanks @smuzaffar!

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2024

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-42b874/43251/summary.html
COMMIT: f61656e
CMSSW: CMSSW_15_0_X_2024-12-04-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46870/43251/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
2024.202001 step 1
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-42b874/43252/summary.html
COMMIT: f61656e
CMSSW: CMSSW_15_0_DEVEL_X_2024-12-04-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46870/43252/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
2024.202001 step 1
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

@smuzaffar
Copy link
Contributor Author

+core

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @mandrenguyen, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar
Copy link
Contributor Author

urgent

@smuzaffar
Copy link
Contributor Author

type bugfix

@smuzaffar
Copy link
Contributor Author

@cms-sw/orp-l2 , can you please review this?

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit debfdce into cms-sw:master Dec 5, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FW Reflection unit test failing: edmClassVersionCheck
4 participants