Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.1.X]Class version update unit test fix #46873

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

smuzaffar
Copy link
Contributor

backport of #46870

@smuzaffar
Copy link
Contributor Author

type bugfix

@smuzaffar
Copy link
Contributor Author

urgent

@cmsbuild cmsbuild added this to the CMSSW_14_1_X milestone Dec 5, 2024
@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2024

A new Pull Request was created by @smuzaffar for CMSSW_14_1_X.

It involves the following packages:

  • FWCore/Reflection (core)

@Dr15Jones, @makortel, @smuzaffar can you please review it and eventually sign? Thanks.
@makortel, @missirol, @wddgit this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2024

cms-bot internal usage

@smuzaffar
Copy link
Contributor Author

+core

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2024

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_1_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_15_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @mandrenguyen, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar smuzaffar changed the title Class version update unit test fix [14.1.X]Class version update unit test fix Dec 5, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2024

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9a91cc/43262/summary.html
COMMIT: 8f7fbab
CMSSW: CMSSW_14_1_X_2024-12-04-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46873/43262/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • Reco comparison results: 11 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3565709
  • DQMHistoTests: Total failures: 39
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3565650
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
  • Checked 199 log files, 169 edm output root files, 46 DQM output files
  • TriggerResults: no differences found

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 7c596b2 into cms-sw:CMSSW_14_1_X Dec 5, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants