Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.2.X]Class version update unit test fix #46872

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

smuzaffar
Copy link
Contributor

backport of #46870

@smuzaffar
Copy link
Contributor Author

type bugfix

@smuzaffar
Copy link
Contributor Author

urgent

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2024

A new Pull Request was created by @smuzaffar for CMSSW_14_2_X.

It involves the following packages:

  • FWCore/Reflection (core)

@Dr15Jones, @makortel, @smuzaffar can you please review it and eventually sign? Thanks.
@makortel, @missirol, @wddgit this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2024

cms-bot internal usage

@smuzaffar
Copy link
Contributor Author

+core

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2024

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_2_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_15_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @mandrenguyen, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2024

-1

Failed Tests: RelVals
Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-64190d/43261/summary.html
COMMIT: b532384
CMSSW: CMSSW_14_2_X_2024-12-04-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46872/43261/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

  • 2024.303001DAS Error
  • 2022.002001DAS Error
  • 2024.000001DAS Error
Expand to see more relval errors ...
  • 2024.101001
  • 2022.000001
  • 2024.202001
  • 2023.002001

@smuzaffar
Copy link
Contributor Author

relval failures are due to das issue and are not related to this change. This change only touches a bash script for running class version unit test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2024

-1

Failed Tests: RelVals
Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-64190d/43261/summary.html
COMMIT: b532384
CMSSW: CMSSW_14_2_X_2024-12-04-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46872/43261/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

  • 2024.303001DAS Error
  • 2022.002001DAS Error
  • 2024.000001DAS Error
Expand to see more relval errors ...
  • 2024.101001
  • 2022.000001
  • 2024.202001
  • 2023.002001

@smuzaffar
Copy link
Contributor Author

ignore tests-rejected with external-failure

@smuzaffar
Copy link
Contributor Author

@cms-sw/orp-l2 , can you please review this? This should fix the build/unit test issue for 14.2.x IBs

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 67e50bd into cms-sw:CMSSW_14_2_X Dec 5, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants