LST algorithm developments accumulated during integration PR

[ariostas]

This PR integrates accumulated LST algorithm developments held back during the review of the LST integration (#45117). The full list of PRs that are included here can be found in SegmentLinking#117. This is our first step in our list of follow-up tasks (#46746).

The changes include bug fixes and algorithmic improvements, but they also start to address follow-up comments from the integration PR. Here are some highlights.

• Improved support of minimal pt for track reconstruction (expanding also to 0.6 GeV) and made it configurable at runtime (addressing CMSSW Integration of LST #45117 (comment)).
• Several updates to T5 DNN selection now replacing most of the algorithmic/rectangular cuts including Jupyter notebooks for documentation.
• Helix-based chi2 in rz improvement for pT5 and introduction for T3 objects.
• Other improvements and fixes, including developments in the standalone code.
• Addressed some follow-up comments from the integration PR (CMSSW Integration of LST #45117 (comment), CMSSW Integration of LST #45117 (comment), first bullet point of CMSSW Integration of LST #45117 (comment))

Most of these were described in TRK POG presentation on Sep 9

Here is a plot showing the impact from these changes on the performance.

@slava77 @VourMa

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46857/42885

• There are other open Pull requests which might conflict with changes you have proposed:
  • File RecoTracker/LSTCore/BuildFile.xml modified in PR(s): Remove the explicit dependency on non-alpaka main library #46829
  • File RecoTracker/LSTCore/interface/Common.h modified in PR(s): Addition of single iteration Patatrack and LST HLT configurations and workflows #46828

[cmsbuild]

A new Pull Request was created by @ariostas for master.

It involves the following packages:

• RecoTracker/LST (reconstruction)
• RecoTracker/LSTCore (reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @VinInn, @VourMa, @dgulhan, @felicepantaleo, @gpetruc, @missirol, @mmusich, @mtosi, @rovere this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[slava77]

test parameters:

• enable_tests = gpu
• workflows_gpu = 24834.704
• workflows = 24834.703
• relvals_opt = -w upgrade,standard
• relvals_opt_gpu = -w upgrade,standard

[slava77]

• relvals_opt = -w upgrade,standard
• relvals_opt_gpu = -w upgrade,standard
  I'm not sure the ,standard is actually needed, but an extra shouldn't harm, I hope.

[slava77]

@cmsbuild please test

[cmsbuild]

+1

Size: This PR adds an extra 1572KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-46fad1/43232/summary.html
COMMIT: 8c9753d
CMSSW: CMSSW_15_0_X_2024-12-03-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46857/43232/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 147 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3629431
• DQMHistoTests: Total failures: 1464
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3627947
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 210 log files, 180 edm output root files, 48 DQM output files
• TriggerResults: no differences found

GPU Comparison Summary

Summary:

• You potentially removed 1 lines from the logs
• Reco comparison results: 117 differences found in the comparisons
• DQMHistoTests: Total files compared: 8
• DQMHistoTests: Total histograms compared: 85217
• DQMHistoTests: Total failures: 96
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 85121
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 7 files compared)
• Checked 28 log files, 33 edm output root files, 8 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1