Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Inputs for D110 And Enabling HIN Phase2 Wf #46355

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

AdrianoDee
Copy link
Contributor

PR description:

This PR proposes to update the default inputs for D110 wfs to a newer set of GEN-SIM (produced in 14_1_0) and to enable the wfs for HIN Phase2.

PR validation:

New inputs works fine.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 11, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46355/42187

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @AdrianoDee for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (upgrade, pdmv)

@AdrianoDee, @Moanwar, @cmsbuild, @kskovpen, @miquork, @srimanob, @subirsarkar, @sunilUIET can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @makortel, @missirol, @slomeo this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@AdrianoDee
Copy link
Contributor Author

test parameters:

  • relval_opts = -w upgrade
  • workflows = 29751.85

@AdrianoDee
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 64KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fd0520/42130/summary.html
COMMIT: d0dc02c
CMSSW: CMSSW_14_2_X_2024-10-11-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46355/42130/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3468 differences found in the comparisons
  • DQMHistoTests: Total files compared: 45
  • DQMHistoTests: Total histograms compared: 3429312
  • DQMHistoTests: Total failures: 45689
  • DQMHistoTests: Total nulls: 71
  • DQMHistoTests: Total successes: 3383532
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
  • Checked 198 log files, 167 edm output root files, 45 DQM output files
  • TriggerResults: found differences in 1 / 43 workflows

@AdrianoDee
Copy link
Contributor Author

+pdmv

@AdrianoDee
Copy link
Contributor Author

@cms-sw/upgrade-l2 gentle ping :)

@Moanwar
Copy link
Contributor

Moanwar commented Oct 28, 2024

+Upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 8cb0aec into cms-sw:master Oct 28, 2024
12 checks passed
@AdrianoDee AdrianoDee deleted the new_d110_inputs_oct24_142X branch November 8, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants