-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NanoAOD] Add ParticleNet-based Muon ID (Rework of #46153) #46273
Conversation
cms-bot internal usage |
test parameters:
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46273/42096
|
A new Pull Request was created by @hqucms for master. It involves the following packages:
@cmsbuild, @ftorrresd, @hqucms, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Size: This PR adds an extra 60KB to repository Comparison SummarySummary:
NANO Comparison SummarySummary:
Nano size comparison Summary:
|
@jlidrych Could you please check the implementations here and make sure everything is correct? Please also provide a comparison of the model output using this NanoAOD-based implementation vs the training framework to see if the results agree with each other. |
My apologies for slow reply. |
Pull request #46273 was updated. @ftorrresd, @hqucms, @jfernan2, @mandrenguyen can you please check and sign again. |
-1 Failed Tests: RelVals-INPUT The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here:
RelVals-INPUT
Expand to see more relval errors ...
Comparison SummarySummary:
NANO Comparison SummarySummary:
Nano size comparison Summary:
|
+1 |
ignore tests-rejected with ib-failure The dasquery failures are also present in the IBs. |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (test failures were overridden). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @mandrenguyen, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
I'm seeing an error that I believe comes from this PR:
Can you take a look? |
^^ I think this was due to a delay in the 11AM IB becoming available such that the external cms-data was not found. I think you can disregard. Sorry for the noise. |
PR description:
Rework of #46153.
The updated model file is in cms-data/PhysicsTools-NanoAOD#18.
PR validation:
runTheMatrix.py -w nano --ibeos -l 2500.211