Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add models for PNet MuonID (Rework of #17) #18

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

hqucms
Copy link
Contributor

@hqucms hqucms commented Oct 4, 2024

Minor changes to #17:

  • Modified the preprocess.json to enable dynamic padding, which brings ~2x speedup. Verified that it produces consistent outputs, up to numerical precision level (~1e-5).
  • Changed pf_mask to PF_mask for naming consistency.

Original PR description:

This PR adds models for PNet Muon ID.

This PR is related to this cms-sw/cmssw#46153.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2024

A new Pull Request was created by @hqucms for branch master.

@aandvalenzuela, @cmsbuild, @ftorrresd, @hqucms, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2024

cms-bot internal usage

@hqucms
Copy link
Contributor Author

hqucms commented Oct 29, 2024

+1

@hqucms hqucms mentioned this pull request Oct 29, 2024
@hqucms hqucms changed the title Rework of #17 -- Add models for PNet MuonID Add models for PNet MuonID (Rework of #17) Oct 29, 2024
@cmsbuild
Copy link
Contributor

REMINDER @rappoccio, @sextonkennedy, @mandrenguyen, @antoniovilela: This PR was tested with cms-sw/cmssw#46273, please check if they should be merged together

@mandrenguyen
Copy link

+1

@mandrenguyen
Copy link

merge

@cmsbuild cmsbuild merged commit 401c4f1 into cms-data:master Oct 31, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants