Run3-hcx369 Allow only valid ZDChits to enter the digitization phase #46286
Conversation
|
cms-bot internal usage |
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46286/42107 Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46286/42108 |
|
A new Pull Request was created by @bsunanda for master. It involves the following packages:
@Dr15Jones, @bsunanda, @civanch, @cmsbuild, @kpedro88, @makortel, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild Please test |
… digitiztion (backport cms-sw#46286)
|
+1 Size: This PR adds an extra 28KB to repository Comparison SummarySummary:
|
|
Mat be it's worth also checking the relevant HI wfs 180.1 and 181.1 ? 🤔 |
| for (unsigned int i = 0; i < zdcHitsOrig.size(); i++) { | ||
| DetId id(zdcHitsOrig[i].id()); | ||
| HcalZDCDetId hid(id); | ||
| if (!ztopoP->valid(hid)) { |
There was a problem hiding this comment.
@bsunanda , in real run there will be many events. Is it correct to have unlimited printouts of wrong ZDC hits?
There was a problem hiding this comment.
I shall protect the printout of good ones - but the wrong DetId is an error and should not happen in normal runs. We have similar error printouts for HCAL which do not produce large printouts
|
I have tested 180.1 with 5000 events before sending this PR. I shall do it for 181.1 for a similar number of events. I cannot do for larger statistics |
|
+1 |
cmsbuild
added
geometry-approved
simulation-approved
fully-signed
and removed
simulation-pending
geometry-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
Great! |
|
Thank you @bsunanda for the fix! |
Run3-hcx370 Protection to avoid unphysical ZDC SimHits which caused crashes during digitization (backport #46286)
PR description:
Allow only valid ZDChits to enter the digitization phase
PR validation:
Use runTheMatrix test workflows
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
May be required to be back ported