Run3-hcx370 Protection to avoid unphysical ZDC SimHits which caused crashes during digitization (backport #46286)

[bsunanda]

PR description:

Protection to avoid unphysical ZDC SimHits which caused crashes during digitization (backport #46286)

PR validation:

Use the runTheMatrix test workflows

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #46286

[cmsbuild]

A new Pull Request was created by @bsunanda for CMSSW_14_1_X.

It involves the following packages:

• Geometry/ForwardGeometry (geometry)
• SimCalorimetry/HcalSimProducers (simulation)

@Dr15Jones, @bsunanda, @civanch, @cmsbuild, @kpedro88, @makortel, @mdhildreth can you please review it and eventually sign? Thanks.
@abdoulline, @fabiocos, @mariadalfonso, @martinamalberti, @rovere, @sameasy this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

• Backported from Run3-hcx369 Allow only valid ZDChits to enter the digitization phase #46286

[cmsbuild]

cms-bot internal usage

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a716f4/42029/summary.html
COMMIT: 7f37093
CMSSW: CMSSW_14_1_X_2024-10-07-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46292/42029/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 6 lines to the logs
• Reco comparison results: 103 differences found in the comparisons
• DQMHistoTests: Total files compared: 44
• DQMHistoTests: Total histograms compared: 3331166
• DQMHistoTests: Total failures: 3235
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3327911
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
• Checked 191 log files, 161 edm output root files, 44 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[bsunanda]

@mandrenguyen, @rappoccio, @antoniovilela Please merge this for 14_1_X

[mandrenguyen]

+1

[mandrenguyen]

backport of #46286