[14_0_X] Removal of ZDC Digitizer

[abdoulline]

PR description:

This is 14_0_X-specific "quick and dirty" patch in view of the 2024 MC production issues, discussed in #43582

PR validation:

One of the problematic wfs (crashing on ev.33) 180.1 ran OK over 1000 ev

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

It's not intended for 14_1_X/14_2_X

[cmsbuild]

A new Pull Request was created by @abdoulline for CMSSW_14_0_X.

It involves the following packages:

• SimCalorimetry/HcalSimProducers (simulation)

@civanch, @cmsbuild, @kpedro88, @mdhildreth can you please review it and eventually sign? Thanks.
@bsunanda, @mariadalfonso, @rovere, @sameasy this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

cms-bot internal usage

[civanch]

please test

[vlimant]

urgent

[cmsbuild]

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e7e6ca/42012/summary.html
COMMIT: 9fcea9f
CMSSW: CMSSW_14_0_X_2024-10-07-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46282/42012/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 98 lines to the logs
• Reco comparison results: 36465 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3349140
• DQMHistoTests: Total failures: 63183
• DQMHistoTests: Total nulls: 72
• DQMHistoTests: Total successes: 3285865
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -1.5219999999999998 KiB( 47 files compared)
• DQMHistoSizes: changed ( 13034.0 ): -0.352 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 250202.181 ): 0.182 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 25202.0 ): 0.303 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 7.3 ): 1.974 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 8.0 ): -3.629 KiB SiStrip/MechanicalView
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: found differences in 8 / 46 workflows

[civanch]

+1

big difference in regresion connected with change of random number sequence

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[bsunanda]

Shall I backport #46286 to 14_0_X? If so, then please do not merge this PR. The backport and this PR will have conflicts

[bsunanda]

Backport of #46286 allows ZDC digitization to be active while protects against bad ZDC DetIds

[abdoulline]

Backport of #46286 allows ZDC digitization to be active while protects against bad ZDC DetIds

I'm closing this PR then.

[abdoulline]

In favor of Sunanda's more complete solution.
(even if nobody needs legacy ZDC Digi).

[vlimant]

silencing the digitizer all together in 14.0 is a much safer solution IMO, instead of backporting bugfixes to shady situations (how can a detid unkwon ... )

[abdoulline]

OK, let me reopen it "just in case"...

[mandrenguyen]

hold
Just so we don't actually merge it (instead of || in addition to) the preferred solution

[cmsbuild]

Pull request has been put on hold by @mandrenguyen
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

[civanch]

Hi all,

one extra argument do not merge this PR but give a favor to #46300 : if we have the same approch to handle ZDC 14_0, 14_1, 14_2 it will give chance fully understand the problem in future and provide full fix without spliting branches for different fixes.

The idea of this fix to add a filter, which exclude bad ZDC IDs seems to be safe, at least, to me.

[bsunanda]

ZdcTopology object needs to be created by ESProducer in solutions of 14_1_X and 14_2_X. So the solution to HcalDigitizer is somewhat different in the 3 versions. All future versions will make use the solution in 14_1_X and 14_2_X. Since 14_0_X is a closed release and there is some doubt if the backport of #46246 will be accepted, this is shorter solution to fix the issue. If the backport #46246 is still alive we need to change this fix and also modify #46246

[civanch]

then this PR should be unhold and #46300 should be closed.

[mandrenguyen]

unhold

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1