Run3-hcx367 Backport #45511 #46033 for the changes to the ZDC geometry #46246

bsunanda · 2024-10-04T07:23:52Z

PR description:

Backport #45511 #46033 for the changes to the ZDC geometry

PR validation:

Use the runTheMatrix test workflows

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backports of several PRs which are merged to the master

cmsbuild · 2024-10-04T07:24:15Z

A new Pull Request was created by @bsunanda for CMSSW_14_0_X.

It involves the following packages:

CalibCalorimetry/HcalPlugins (alca)
CondFormats/HcalObjects (db, alca)
CondTools/Geometry (db)
Configuration/Geometry (geometry, upgrade)
Geometry/CaloGeometry (geometry)
Geometry/CaloTopology (geometry)
Geometry/ForwardCommonData (geometry)
Geometry/ForwardGeometry (geometry)
Geometry/HcalCommonData (geometry)
Geometry/Records (geometry)
HLTrigger/Configuration (hlt)
SimCalorimetry/HcalSimProducers (simulation)
SimCalorimetry/HcalTrigPrimProducers (l1)

@Dr15Jones, @Martin-Grunewald, @Moanwar, @aloeliger, @atpathak, @bsunanda, @civanch, @cmsbuild, @consuegs, @epalencia, @francescobrivio, @kpedro88, @makortel, @mdhildreth, @mmusich, @perrotta, @srimanob, @subirsarkar can you please review it and eventually sign? Thanks.
@JanChyczynski, @Martin-Grunewald, @PonIlya, @ReyerBand, @abdoulline, @argiro, @fabiocos, @mariadalfonso, @martinamalberti, @missirol, @mmusich, @rchatter, @rovere, @rsreds, @sameasy, @seemasharmafnal, @silviodonato, @slomeo, @thomreis, @tocheng, @vargasa, @wang0jin, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2024-10-04T07:24:16Z

cms-bot internal usage

bsunanda · 2024-10-04T07:27:44Z

@cmsbuild Please test

Martin-Grunewald · 2024-10-04T07:30:49Z

HLTrigger/Configuration/python/customizeHLTforCMSSW.py

@@ -270,5 +281,6 @@ def customizeHLTforCMSSW(process, menuType="GRun"):
    # process = customiseFor12718(process)

    process = checkHLTfor43774(process)
+    process = customizeHLTfor46062(process)


This is problematic if it needs to go into a 14_0 release for 2024 data taking - given that HLT development has moved to 14_1 already (online does not use these customisations). So can this PR be deferred until P5/T0 has moved to 14_1?

It may be used for MC production and not dor data taking

Martin-Grunewald · 2024-10-04T07:34:05Z

HLTrigger/Configuration/python/customizeHLTforCMSSW.py

@@ -221,6 +221,17 @@ def customiseFor2018Input(process):
    return process


+# Adding zdc Topology producer
+def customizeHLTfor46062(process):


Here and below, should probably be 46246.

cmsbuild · 2024-10-04T14:54:31Z

Pull request #46246 was updated. @Dr15Jones, @Martin-Grunewald, @Moanwar, @aloeliger, @atpathak, @bsunanda, @civanch, @cmsbuild, @consuegs, @epalencia, @francescobrivio, @kpedro88, @makortel, @mdhildreth, @mmusich, @perrotta, @srimanob, @subirsarkar can you please check and sign again.

bsunanda · 2024-10-04T14:54:40Z

@cmsbuild Please test

cmsbuild · 2024-10-04T22:39:21Z

-1

Failed Tests: UnitTests
Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14af4a/41978/summary.html
COMMIT: d1502f1
CMSSW: CMSSW_14_0_X_2024-10-04-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46246/41978/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test test2021Geometry had ERRORS

Comparison Summary

Summary:

You potentially added 76 lines to the logs
Reco comparison results: 24374 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3349140
DQMHistoTests: Total failures: 53292
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 3295827
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -1.5219999999999998 KiB( 47 files compared)
DQMHistoSizes: changed ( 13034.0 ): -0.352 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 250202.181 ): 0.182 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 25202.0 ): 0.303 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 7.3 ): 1.974 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 8.0 ): -3.629 KiB SiStrip/MechanicalView
Checked 202 log files, 165 edm output root files, 48 DQM output files
TriggerResults: found differences in 5 / 46 workflows

cmsbuild · 2024-10-05T05:58:15Z

Pull request #46246 was updated. @Dr15Jones, @Martin-Grunewald, @Moanwar, @aloeliger, @atpathak, @bsunanda, @civanch, @cmsbuild, @consuegs, @epalencia, @francescobrivio, @kpedro88, @makortel, @mdhildreth, @mmusich, @perrotta, @srimanob, @subirsarkar can you please check and sign again.

bsunanda · 2024-10-05T06:06:50Z

@cmsbuild Please test

cmsbuild · 2024-10-05T13:53:28Z

+1

Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14af4a/41987/summary.html
COMMIT: 89dfa0f
CMSSW: CMSSW_14_0_X_2024-10-04-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46246/41987/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 42 lines to the logs
Reco comparison results: 24379 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3349140
DQMHistoTests: Total failures: 53293
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 3295826
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -1.5219999999999998 KiB( 47 files compared)
DQMHistoSizes: changed ( 13034.0 ): -0.352 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 250202.181 ): 0.182 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 25202.0 ): 0.303 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 7.3 ): 1.974 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 8.0 ): -3.629 KiB SiStrip/MechanicalView
Checked 202 log files, 165 edm output root files, 48 DQM output files
TriggerResults: found differences in 5 / 46 workflows

mandrenguyen · 2024-10-05T14:19:29Z

What is the reason to backport this into 14_0_X?
The ZDC will never be used with this release.

vlimant · 2024-10-06T09:34:30Z

#43582 would be a reason ; trying to let pp simulation go through in 14.0 . Summer24 production is blocked because of this.
backport might not be the best solution indeed, but we need something to have 14.0 usable for MC production

mmusich · 2024-10-06T10:48:24Z

trying to let pp simulation go through in 14.0 . Summer24 production is blocked because of this.
backport might not be the best solution indeed, but we need something to have 14.0 usable for MC production

in order to let the Summer24 MC production in 14.0.X go ahead without introducing unrequested / unwanted features in 14.0.X (see #46246 (comment)) which would also complicate the life of other stakeholders (e.g. TSG see #46246 (comment)) would killing any attempt to digitize ZDC SimHits (as suggested by @abdoulline at #43582 (comment) ) be an option?

vlimant · 2024-10-07T12:12:56Z

NB #46282

mmusich · 2024-10-08T08:28:23Z

@bsunanda is this PR still needed after #46300 ?

mmusich · 2024-10-08T09:05:53Z

-hlt

see Run3-hcx367 Backport #45511 #46033 for the changes to the ZDC geometry #46246 (comment), until a valid reason to backport is presented

bsunanda · 2024-10-09T09:37:26Z

If no MC production will be done with CMSSW_14_0_X using the 2023/2024 geometries, this backport may not be required.

perrotta · 2024-10-14T13:29:05Z

If no MC production will be done with CMSSW_14_0_X using the 2023/2024 geometries, this backport may not be required.

Yes, @bsunanda : please close it

perrotta · 2024-10-14T13:29:17Z

-alca

perrotta · 2024-10-14T13:29:23Z

-db

bsunanda · 2024-10-14T14:37:26Z

Closing this PR since no MC production of ZDC will be done using 14_0_X

Bckport cms-sw#45511 #46033fo the changes t zDC geometry

9352017

cmsbuild added this to the CMSSW_14_0_X milestone Oct 4, 2024

cmsbuild added simulation-pending l1-pending hlt-pending alca-pending db-pending geometry-pending pending-signatures tests-pending orp-pending upgrade-pending labels Oct 4, 2024

cmsbuild added tests-started and removed tests-pending labels Oct 4, 2024

Martin-Grunewald reviewed Oct 4, 2024

View reviewed changes

change the nam of a customisation

d1502f1

cmsbuild added tests-pending and removed tests-started labels Oct 4, 2024

cmsbuild added tests-started and removed tests-pending labels Oct 4, 2024

cmsbuild added tests-rejected and removed tests-started labels Oct 4, 2024

Avoid unit test failure

89dfa0f

cmsbuild added tests-pending and removed tests-rejected labels Oct 5, 2024

cmsbuild added tests-started and removed tests-pending labels Oct 5, 2024

cmsbuild added tests-approved and removed tests-started labels Oct 5, 2024

abdoulline mentioned this pull request Oct 5, 2024

[14_0_X SIM] ZDC problem in hlt_mc_HIon test #43582

Open

cmsbuild added hlt-rejected and removed hlt-pending labels Oct 8, 2024

bsunanda mentioned this pull request Oct 8, 2024

[14_0_X] Removal of ZDC Digitizer #46282

Merged

cmsbuild added alca-rejected db-rejected and removed alca-pending db-pending labels Oct 14, 2024

bsunanda closed this Oct 14, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Run3-hcx367 Backport #45511 #46033 for the changes to the ZDC geometry #46246

Run3-hcx367 Backport #45511 #46033 for the changes to the ZDC geometry #46246

bsunanda commented Oct 4, 2024

cmsbuild commented Oct 4, 2024

cmsbuild commented Oct 4, 2024 •

edited

Loading

bsunanda commented Oct 4, 2024

Martin-Grunewald Oct 4, 2024 •

edited

Loading

bsunanda Oct 4, 2024

Martin-Grunewald Oct 4, 2024

bsunanda Oct 4, 2024

cmsbuild commented Oct 4, 2024

bsunanda commented Oct 4, 2024

cmsbuild commented Oct 4, 2024

cmsbuild commented Oct 5, 2024

bsunanda commented Oct 5, 2024

cmsbuild commented Oct 5, 2024

mandrenguyen commented Oct 5, 2024

vlimant commented Oct 6, 2024

mmusich commented Oct 6, 2024 •

edited

Loading

vlimant commented Oct 7, 2024

mmusich commented Oct 8, 2024

mmusich commented Oct 8, 2024

bsunanda commented Oct 9, 2024

perrotta commented Oct 14, 2024

perrotta commented Oct 14, 2024

perrotta commented Oct 14, 2024

bsunanda commented Oct 14, 2024

Run3-hcx367 Backport #45511 #46033 for the changes to the ZDC geometry #46246

Run3-hcx367 Backport #45511 #46033 for the changes to the ZDC geometry #46246

Conversation

bsunanda commented Oct 4, 2024

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

cmsbuild commented Oct 4, 2024

cmsbuild commented Oct 4, 2024 • edited Loading

bsunanda commented Oct 4, 2024

Martin-Grunewald Oct 4, 2024 • edited Loading

Choose a reason for hiding this comment

bsunanda Oct 4, 2024

Choose a reason for hiding this comment

Martin-Grunewald Oct 4, 2024

Choose a reason for hiding this comment

bsunanda Oct 4, 2024

Choose a reason for hiding this comment

cmsbuild commented Oct 4, 2024

bsunanda commented Oct 4, 2024

cmsbuild commented Oct 4, 2024

Unit Tests

Comparison Summary

cmsbuild commented Oct 5, 2024

bsunanda commented Oct 5, 2024

cmsbuild commented Oct 5, 2024

Comparison Summary

mandrenguyen commented Oct 5, 2024

vlimant commented Oct 6, 2024

mmusich commented Oct 6, 2024 • edited Loading

vlimant commented Oct 7, 2024

mmusich commented Oct 8, 2024

mmusich commented Oct 8, 2024

bsunanda commented Oct 9, 2024

perrotta commented Oct 14, 2024

perrotta commented Oct 14, 2024

perrotta commented Oct 14, 2024

bsunanda commented Oct 14, 2024

cmsbuild commented Oct 4, 2024 •

edited

Loading

Martin-Grunewald Oct 4, 2024 •

edited

Loading

mmusich commented Oct 6, 2024 •

edited

Loading