Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset Pixel Dead ROCs map Online GUI (BP to 14_1_X) #45957

Merged

Conversation

alaperto
Copy link
Contributor

@alaperto alaperto commented Sep 9, 2024

PR description:

In the Online DQM GUI: reset Dead channels per ROC every 10 LS (as other maps) to improve Online DQM shifter understanding.

PR validation:

Data produced with cmsRun, i.e.:

cmsRun DQM/Integration/python/clients/pixel_dqm_sourceclient-live_cfg.py dataset=/ZeroBias/Run2024G-v1/RAW runNumber=385311

Results checked in private Online QUI (to access need lxplus tunneling):

385311

####About backport:

This is a Backport to 14_1_X of PR #45955

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2024

cms-bot internal usage

@iarspider
Copy link
Contributor

@alaperto could you please update CMSSW_14_1_X branch in your local repo and rebase your changes? Thanks!

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45957/41714

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2024

A new Pull Request was created by @alaperto for master.

It involves the following packages:

  • CondCore/Utilities (db)
  • Configuration/PyReleaseValidation (pdmv, upgrade)
  • DQM/GEM (dqm)
  • DQM/Integration (dqm)
  • DQM/L1TMonitor (dqm)
  • DQM/SiPixelHeterogeneous (dqm)
  • DQM/SiPixelPhase1Summary (dqm)
  • DataFormats/TrackingRecHitSoA (reconstruction, heterogeneous)
  • Geometry/HGCalCommonData (geometry, upgrade)
  • Geometry/HGCalGeometry (geometry, upgrade)
  • L1Trigger/L1TCaloLayer1 (l1)
  • PhysicsTools/PatAlgos (xpog, reconstruction)
  • RecoLocalCalo/HGCalRecAlgos (reconstruction, upgrade)
  • RecoTracker/PixelSeeding (reconstruction)
  • SimG4CMS/Calo (simulation)
  • Validation/Geometry (dqm, geometry)
  • Validation/HGCalValidation (dqm)

@AdrianoDee, @Dr15Jones, @aloeliger, @antoniovagnerini, @bsunanda, @civanch, @cmsbuild, @consuegs, @epalencia, @francescobrivio, @ftorrresd, @fwyzard, @hqucms, @jfernan2, @kskovpen, @makortel, @mandrenguyen, @mdhildreth, @miquork, @nothingface0, @perrotta, @rvenditti, @saumyaphor4252, @srimanob, @subirsarkar, @sunilUIET, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@AlexDeMoor, @GiacomoSguazzoni, @JanChyczynski, @JanFSchulte, @Martin-Grunewald, @Ming-Yan, @PonIlya, @ReyerBand, @Senphy, @VinInn, @VourMa, @ahinzmann, @andrzejnovak, @apsallid, @argiro, @arossi83, @azotz, @batinkov, @bsunanda, @castaned, @cseez, @demuller, @dgulhan, @edjtscott, @fabiocos, @felicepantaleo, @fioriNTU, @francescobrivio, @gkasieczka, @gouskos, @gpetruc, @hatakeyamak, @idebruyn, @jandrea, @jdamgov, @jdolen, @lecriste, @lgray, @makortel, @mariadalfonso, @martinamalberti, @mbluj, @missirol, @mmarionncern, @mmusich, @mtosi, @nhanvtran, @pfs, @rappoccio, @rbartek, @rchatter, @rishabhCMS, @rovere, @rsreds, @sameasy, @schoef, @seemasharmafnal, @sethzenz, @slomeo, @sroychow, @thomreis, @threus, @vandreev11, @vargasa, @wang0jin, @watson-ij, @youyingli, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor

makortel commented Sep 9, 2024

@alaperto could you please update CMSSW_14_1_X branch in your local repo and rebase your changes? Thanks!

It seems to me the base branch of the PR should be changed from master to CMSSW_14_1_X.

@alaperto alaperto changed the base branch from master to CMSSW_14_1_X September 9, 2024 14:03
@cmsbuild cmsbuild modified the milestones: CMSSW_14_2_X, CMSSW_14_1_X Sep 9, 2024
@alaperto
Copy link
Contributor Author

alaperto commented Sep 9, 2024

@makortel @iarspider sorry, fixed!

@makortel
Copy link
Contributor

makortel commented Sep 9, 2024

Thanks!

@makortel
Copy link
Contributor

makortel commented Sep 9, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2024

+1

Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-583aba/41414/summary.html
COMMIT: fcfd2c0
CMSSW: CMSSW_14_1_X_2024-09-09-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45957/41414/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 44
  • DQMHistoTests: Total histograms compared: 3328391
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3328365
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
  • Checked 191 log files, 161 edm output root files, 44 DQM output files
  • TriggerResults: no differences found

@antoniovagnerini
Copy link

backport of #45955

@antoniovagnerini
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @mandrenguyen, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 18a82f1 into cms-sw:CMSSW_14_1_X Sep 12, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants