Protect ECAL time reconstruction for events without EB [14.0.x]

[fwyzard]

PR description:

Protect the ECAL time reconstruction for events without any rechits in the ECAL barrel.

PR validation:

Fixes HLT crashes observed in run 382460, described in #45312.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #45311 to 14.0.x for data taking.

[fwyzard]

backport #45311

[fwyzard]

type ecal

[fwyzard]

type bugfix

[fwyzard]

urgent

[fwyzard]

enable gpu

[cmsbuild]

A new Pull Request was created by @fwyzard for CMSSW_14_0_X.

It involves the following packages:

• RecoLocalCalo/EcalRecProducers (reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@ReyerBand, @apsallid, @argiro, @missirol, @rchatter, @thomreis, @wang0jin, @youyingli this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

• Backported from Protect ECAL time reconstruction for events without EB #45311

[cmsbuild]

cms-bot internal usage

[fwyzard]

please test

[fwyzard]

fixes #45312

[cmsbuild]

Pull request #45313 was updated. @cmsbuild, @jfernan2, @mandrenguyen can you please check and sign again.

[fwyzard]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-226877/40092/summary.html
COMMIT: fef0757
CMSSW: CMSSW_14_0_X_2024-06-26-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45313/40092/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 62 lines from the logs
• Reco comparison results: 138 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3342528
• DQMHistoTests: Total failures: 2577
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3339931
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

GPU Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 23 differences found in the comparisons
• DQMHistoTests: Total files compared: 3
• DQMHistoTests: Total histograms compared: 39744
• DQMHistoTests: Total failures: 1240
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 38504
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 2 files compared)
• Checked 8 log files, 10 edm output root files, 3 DQM output files
• TriggerResults: no differences found

[mandrenguyen]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1